Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded first-cut implementation of XR layers #26168
Merged
+585
−15
Conversation
highfive
commented
Apr 10, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
Apr 10, 2020
|
|
|
It's still a draft because it needs some tests added. |
|
@Manishearth r? |
|
@bors-servo r=Manishearth |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 13, 2020
Added first-cut implementation of XR layers <!-- Please describe your changes on the following line: --> Starting on an implementation of https://immersive-web.github.io/layers/ This PR doesn't add any new functionality, just the plumbing. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes OR <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedApr 10, 2020
•
edited
Starting on an implementation of https://immersive-web.github.io/layers/
This PR doesn't add any new functionality, just the plumbing.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors