Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FromJSValConvertible for enums #26170

Merged
merged 2 commits into from Apr 12, 2020
Merged

Add FromJSValConvertible for enums #26170

merged 2 commits into from Apr 12, 2020
+25 −8

Conversation

@Manishearth
Copy link
Member

Manishearth commented Apr 11, 2020

Fixes #26169

This adds FromJSValConvertible implementations for webidl enums, which allows them to be used within sequence<>, etc.

This also uses these implementations when converting arguments.
@highfive
Copy link

highfive commented Apr 11, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/bindings/codegen/CodegenRust.py
  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py
@highfive
Copy link

highfive commented Apr 11, 2020

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!
@Manishearth
Copy link
Member Author

Manishearth commented Apr 11, 2020

r? @jdm or @nox
@highfive highfive assigned jdm and unassigned asajeffrey Apr 11, 2020
@Manishearth
Copy link
Member Author

Manishearth commented Apr 11, 2020

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2020

⌛ Trying commit 6fa5878 with merge 5693ba8...
bors-servo added a commit that referenced this pull request Apr 11, 2020
@bors-servo
Auto merge of #26170 - Manishearth:enum-convertible, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5693ba8 
Add FromJSValConvertible for enums

Fixes #26169

This adds FromJSValConvertible implementations for webidl enums, which allows them to be used within `sequence<>`, etc.

This also uses these implementations when converting arguments.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2020

💔 Test failed - status-taskcluster
Manishearth added 2 commits Apr 10, 2020
@Manishearth
Implement FromJSValConvertible on enums
10a13ff
@Manishearth
Use FromJSValConvertible impls when converting arguments
Loading status checks…
242b7f8
@Manishearth Manishearth force-pushed the Manishearth:enum-convertible branch from 6fa5878 to 242b7f8 Apr 11, 2020
@Manishearth Manishearth mentioned this pull request Apr 11, 2020
Merged
@asajeffrey
asajeffrey approved these changes Apr 12, 2020
View changes
Copy link
Member

asajeffrey left a comment

Yes please!
@Manishearth
Copy link
Member Author

Manishearth commented Apr 12, 2020

@bors-servo r=asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Apr 12, 2020

📌 Commit 242b7f8 has been approved by asajeffrey
@highfive highfive assigned asajeffrey and unassigned jdm Apr 12, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Apr 12, 2020

⌛ Testing commit 242b7f8 with merge 3abbfdf...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 12, 2020

☀️ Test successful - status-taskcluster
Approved by: asajeffrey
Pushing 3abbfdf to master...
@bors-servo bors-servo merged commit 3abbfdf into servo:master Apr 12, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
bors-servo added a commit that referenced this pull request Apr 19, 2020
@bors-servo
Auto merge of #26171 - Manishearth:hittest, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0347380 
Implement hit testing API

Depends on servo/webxr#149 , #26170

This implements non-transient hit tests.

The tests that do not pass are due to web-platform-tests/wpt#22898 , web-platform-tests/wpt#22900, web-platform-tests/wpt#22901 , and immersive-web/hit-test#86
bors-servo added a commit that referenced this pull request Apr 20, 2020
@bors-servo
Auto merge of #26171 - Manishearth:hittest, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
575c8ed 
Implement hit testing API

Depends on servo/webxr#149 , #26170

This implements non-transient hit tests.

The tests that do not pass are due to web-platform-tests/wpt#22898 , web-platform-tests/wpt#22900, web-platform-tests/wpt#22901 , and immersive-web/hit-test#86
bors-servo added a commit that referenced this pull request Apr 20, 2020
@bors-servo
Auto merge of #26171 - Manishearth:hittest, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
99cd30e 
Implement hit testing API

Depends on servo/webxr#149 , #26170

This implements non-transient hit tests.

The tests that do not pass are due to web-platform-tests/wpt#22898 , web-platform-tests/wpt#22900, web-platform-tests/wpt#22901 , and immersive-web/hit-test#86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asajeffrey asajeffrey

Assignees

@asajeffrey asajeffrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Should we be using FromJSValConvertible for enum conversions?
5 participants
@Manishearth @highfive @bors-servo @asajeffrey @jdm
You can’t perform that action at this time.