Implement hit testing API #26171

Manishearth · 2020-04-11T07:26:58Z

This implements non-transient hit tests.

The tests that do not pass are due to web-platform-tests/wpt#22898 , web-platform-tests/wpt#22900, web-platform-tests/wpt#22901 , and immersive-web/hit-test#86

highfive · 2020-04-11T07:27:06Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/webidls/XRSession.webidl, components/script/dom/webidls/XRRay.webidl, components/script/canvas_state.rs, components/script/dom/xrreferencespace.rs, components/script/dom/mod.rs and 21 more
@KiChjang: components/script/dom/webidls/XRSession.webidl, components/script/dom/webidls/XRRay.webidl, components/script/canvas_state.rs, components/script/dom/xrreferencespace.rs, components/script/dom/mod.rs and 21 more

highfive · 2020-04-11T07:27:08Z

Warning

These commits modify unsafe code. Please review it carefully!

servo-wpt-sync · 2020-04-11T07:27:31Z

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#22868.

Manishearth · 2020-04-11T16:12:35Z

I haven't gone through all the tests but the reason we fail the refSpace one, for example, is both because of immersive-web/hit-test#86 and because of another bug in the test where it's assuming hit test results get duplicated

servo-wpt-sync · 2020-04-13T16:38:19Z

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#22868.

servo-wpt-sync · 2020-04-14T17:55:25Z

No upstreamable changes; closed existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#22868.

Manishearth · 2020-04-14T17:59:33Z

Rebased over test updates that I landed upstream early.

jdm · 2020-04-14T18:18:18Z

r? @asajeffrey

asajeffrey

Mostly LGTM, we're generating a lot of objects per frame, but hey ho.

One thing I don't understand is how to do hit tests relative to a moving refererence, e.g. from the users's hands or eyes? Does this require generating a new ray each frame?

asajeffrey · 2020-04-15T17:05:34Z

components/script/dom/xrframe.rs

+            .hit_test_results
+            .iter()
+            .filter(|r| r.id == source.id())
+            .map(|r| XRHitTestResult::new(&self.global(), *r, self))


Ouch, creating a new hit test result for each hit test, every frame? This might be putting strain on the GC?

I don't see any other way to do it? Note that it's possible for a single hit test to have multiple results.

asajeffrey · 2020-04-15T17:05:34Z

components/script/dom/xrhittestresult.rs

+    fn GetPose(&self, base: &XRSpace) -> Option<DomRoot<XRPose>> {
+        let base = self.frame.get_pose(base)?;
+        let pose = base.inverse().pre_transform(&self.result.space);
+        Some(XRPose::new(&self.global(), pose.cast_unit()))


Ditto, creating a new XRPose object every frame?

We already do this with getPose in views

CYBAI · 2020-04-16T12:34:47Z

Needs a ./mach fmt 👀

Diff in /repo/components/script/dom/xrsession.rs at line 747:
             .granted_features()
             .iter()
             .find(|f| &**f == "hit-test")
-            .is_none() {
�(B+            .is_none()
�(B+        {
�(B             p.reject_error(Error::NotSupported);
             return p;
         }
clang-format not installed. Skipping CPP formatting.
Run `./mach fmt` to fix the formatting

Manishearth · 2020-04-16T17:04:40Z

Strangely I do not get that error locally

Manishearth · 2020-04-16T17:06:11Z

That patch is also already applied here and on github. I suspect tc is doing something weird.

(tc won't pass anyway until servo/webxr#149 lands)

CYBAI · 2020-04-17T04:03:01Z

Checking files for tidiness...
./Cargo.lock:1: duplicate versions for package `autocfg`
	The following packages depend on version 0.1.7 from 'crates.io':
	The following packages depend on version 1.0.0 from 'crates.io':
./components/script/dom/webidls/XRHitTestResult.webidl:10: no newline at EOF


        Auto merge of #149 - Manishearth:hittest, r=asajeffrey

@jdm

Implement support for hit testing, use in mock backend Servo side: servo/servo#26171 This adds support for all non-transient parts of he [WebXR Hit Test Module](https://immersive-web.github.io/hit-test), including mocking support. This has not yet been hooked up to script and is thus completely untested. r? @jdm


        Update webxr


        Add hit test mocking at initialization


        Add hit test mocking after initialization

Manishearth · 2020-04-19T18:44:29Z

@bors-servo try


        Update XRRay semantics

Implements changes from immersive-web/hit-test#85


        Add XRHitTestSource


        Add XRHitTestResult


        Add XRHitTestResult::getPose


        Add XRFrame::getHitTestResults()


        Add XRSession::requestHitTestSource()


        Add feature gating for hit tests


        Update dependencies to dedup autocfg


        Update interfaces.html test

Manishearth · 2020-04-20T03:29:33Z

Ah, our webxr tests need to be updated for supportedModes

Manishearth · 2020-04-20T03:29:41Z

@bors-servo r=asajeffrey

bors-servo · 2020-04-20T03:29:42Z

📌 Commit 2a57966 has been approved by asajeffrey

bors-servo · 2020-04-20T03:29:47Z

⌛ Testing commit 2a57966 with merge 575c8ed...


        Auto merge of #26171 - Manishearth:hittest, r=asajeffrey

Implement hit testing API Depends on servo/webxr#149 , #26170 This implements non-transient hit tests. The tests that do not pass are due to web-platform-tests/wpt#22898 , web-platform-tests/wpt#22900, web-platform-tests/wpt#22901 , and immersive-web/hit-test#86

bors-servo · 2020-04-20T04:12:19Z

💔 Test failed - status-taskcluster

jdm · 2020-04-20T04:30:43Z

@bors-servo retry

bors-servo · 2020-04-20T04:30:48Z

⌛ Testing commit 2a57966 with merge 99cd30e...

bors-servo · 2020-04-20T04:48:22Z

☀️ Test successful - status-taskcluster
Approved by: asajeffrey
Pushing 99cd30e to master...

highfive assigned jdm Apr 11, 2020

highfive added the S-awaiting-review label Apr 11, 2020

Manishearth requested a review from jdm Apr 11, 2020

servo-wpt-sync mentioned this pull request Apr 11, 2020

Implement hit testing API web-platform-tests/wpt#22868

Merged

Manishearth mentioned this pull request Apr 11, 2020

Implement support for hit testing, use in mock backend servo/webxr#149

Merged

Manishearth force-pushed the Manishearth:hittest branch from 31e0eee to d40442a Apr 13, 2020

Manishearth force-pushed the Manishearth:hittest branch from d40442a to 3184d61 Apr 14, 2020

highfive assigned asajeffrey and unassigned jdm Apr 14, 2020

Manishearth force-pushed the Manishearth:hittest branch from 3184d61 to 8115657 Apr 14, 2020

asajeffrey approved these changes Apr 15, 2020

View changes

Manishearth force-pushed the Manishearth:hittest branch from 8115657 to 3837bf4 Apr 16, 2020

Manishearth added 3 commits Apr 7, 2020

Update webxr

3f88310

Add hit test mocking at initialization

d01d906

Add hit test mocking after initialization

ef6ee5e

Manishearth force-pushed the Manishearth:hittest branch from 3837bf4 to 4bb19ee Apr 19, 2020

Manishearth added 9 commits Apr 10, 2020

Update XRRay semantics

83f92a3

Implements changes from immersive-web/hit-test#85

Add XRHitTestSource

341d36a

Add XRHitTestResult

c7b9152

Add XRHitTestResult::getPose

87bce8c

Add XRFrame::getHitTestResults()

f1d6a89

Add XRSession::requestHitTestSource()

1b07b77

Add feature gating for hit tests

30cd89d

Update dependencies to dedup autocfg

9659243

Update interfaces.html test

Loading status checks…

2a57966

Manishearth force-pushed the Manishearth:hittest branch from 4bb19ee to 2a57966 Apr 20, 2020

highfive removed the S-tests-failed label Apr 20, 2020

highfive added S-awaiting-merge and removed S-awaiting-review labels Apr 20, 2020

highfive added S-tests-failed and removed S-awaiting-merge labels Apr 20, 2020

highfive added S-awaiting-merge and removed S-tests-failed labels Apr 20, 2020

bors-servo merged commit 99cd30e into servo:master Apr 20, 2020
2 checks passed

2 checks passed

Community-TC (pull_request) TaskGroup: success
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Apr 20, 2020

Manishearth deleted the Manishearth:hittest branch Apr 20, 2020

servo / servo

Implement hit testing API #26171

Implement hit testing API #26171

Manishearth commented Apr 11, 2020 •

edited

highfive commented Apr 11, 2020

highfive commented Apr 11, 2020

servo-wpt-sync commented Apr 11, 2020

Manishearth commented Apr 11, 2020

servo-wpt-sync commented Apr 13, 2020

servo-wpt-sync commented Apr 14, 2020

Manishearth commented Apr 14, 2020

jdm commented Apr 14, 2020

asajeffrey left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

CYBAI commented Apr 16, 2020

Manishearth commented Apr 16, 2020

Manishearth commented Apr 16, 2020

CYBAI commented Apr 17, 2020

Manishearth commented Apr 19, 2020

Manishearth commented Apr 20, 2020

Manishearth commented Apr 20, 2020

bors-servo commented Apr 20, 2020

bors-servo commented Apr 20, 2020

bors-servo commented Apr 20, 2020

jdm commented Apr 20, 2020

bors-servo commented Apr 20, 2020

bors-servo commented Apr 20, 2020

servo / servo

Join GitHub today

Implement hit testing API #26171

Implement hit testing API #26171

Conversation

Manishearth commented Apr 11, 2020 • edited

highfive commented Apr 11, 2020

highfive commented Apr 11, 2020

servo-wpt-sync commented Apr 11, 2020

Manishearth commented Apr 11, 2020

servo-wpt-sync commented Apr 13, 2020

servo-wpt-sync commented Apr 14, 2020

Manishearth commented Apr 14, 2020

jdm commented Apr 14, 2020

asajeffrey left a comment

This comment has been minimized.

asajeffrey Apr 15, 2020

This comment has been minimized.

Manishearth Apr 15, 2020

This comment has been minimized.

asajeffrey Apr 15, 2020

This comment has been minimized.

Manishearth Apr 15, 2020

CYBAI commented Apr 16, 2020

Manishearth commented Apr 16, 2020

Manishearth commented Apr 16, 2020

CYBAI commented Apr 17, 2020

Manishearth commented Apr 19, 2020

Manishearth commented Apr 20, 2020

Manishearth commented Apr 20, 2020

bors-servo commented Apr 20, 2020

bors-servo commented Apr 20, 2020

bors-servo commented Apr 20, 2020

jdm commented Apr 20, 2020

bors-servo commented Apr 20, 2020

bors-servo commented Apr 20, 2020

Manishearth commented Apr 11, 2020 •

edited