Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of soon-to-be-deprecated unstable feature #26190

Merged
merged 4 commits into from Apr 16, 2020
Merged

Remove use of soon-to-be-deprecated unstable feature #26190

merged 4 commits into from Apr 16, 2020
+17 −19

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Apr 15, 2020

rust-lang/rust#47336 (comment)
SimonSapin added 3 commits Apr 15, 2020
@SimonSapin
Remove unused `#![feature(…)]` attributes
fbfe86f
@SimonSapin
Remove use of soon-to-be-deprecated unstable feature
7861b0b 
rust-lang/rust#47336 (comment)
@SimonSapin
Remove use of some other unstable features
Loading status checks…
7f975c3
@highfive
Copy link

highfive commented Apr 15, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/lib.rs, components/script/dom/bindings/root.rs
  • @KiChjang: components/script/lib.rs, components/script/dom/bindings/root.rs
@highfive
Copy link

highfive commented Apr 15, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@SimonSapin
Copy link
Member Author

SimonSapin commented Apr 15, 2020

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Apr 15, 2020

📌 Commit 7f975c3 has been approved by nox
@highfive highfive assigned nox and unassigned asajeffrey Apr 15, 2020
@SimonSapin
Replace a `transmute` with `.to_ne_bytes()` + constructor
Loading status checks…
6175a68
@nox
Copy link
Member

nox commented Apr 15, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 15, 2020

📌 Commit 6175a68 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Apr 15, 2020

⌛ Testing commit 6175a68 with merge 6cd7f0d...
bors-servo added a commit that referenced this pull request Apr 15, 2020
@bors-servo
Auto merge of #26190 - servo:unstable, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6cd7f0d 
Remove use of soon-to-be-deprecated unstable feature

rust-lang/rust#47336 (comment)
@bors-servo
Copy link
Contributor

bors-servo commented Apr 15, 2020

💔 Test failed - status-taskcluster
@SimonSapin
Copy link
Member Author

SimonSapin commented Apr 15, 2020

@bors-servo retry #25513
@bors-servo
Copy link
Contributor

bors-servo commented Apr 15, 2020

⌛ Testing commit 6175a68 with merge 886b712...
bors-servo added a commit that referenced this pull request Apr 15, 2020
@bors-servo
Auto merge of #26190 - servo:unstable, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
886b712 
Remove use of soon-to-be-deprecated unstable feature

rust-lang/rust#47336 (comment)
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Apr 16, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2020

⌛ Testing commit 6175a68 with merge 50112b3...
bors-servo added a commit that referenced this pull request Apr 16, 2020
@bors-servo
Auto merge of #26190 - servo:unstable, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
50112b3 
Remove use of soon-to-be-deprecated unstable feature

rust-lang/rust#47336 (comment)
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Apr 16, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2020

⌛ Testing commit 6175a68 with merge bed20f0...
bors-servo added a commit that referenced this pull request Apr 16, 2020
@bors-servo
Auto merge of #26190 - servo:unstable, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bed20f0 
Remove use of soon-to-be-deprecated unstable feature

rust-lang/rust#47336 (comment)
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2020

💔 Test failed - status-taskcluster
@SimonSapin
Copy link
Member Author

SimonSapin commented Apr 16, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2020

⌛ Testing commit 6175a68 with merge a4fbad2...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2020

☀️ Test successful - status-taskcluster
Approved by: nox
Pushing a4fbad2 to master...
@bors-servo bors-servo merged commit a4fbad2 into master Apr 16, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo deleted the unstable branch Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@SimonSapin @highfive @bors-servo @nox @jdm @asajeffrey
You can’t perform that action at this time.