Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade clang to 9.0 on Windows. #26193

Merged
merged 2 commits into from Apr 16, 2020
Merged

Upgrade clang to 9.0 on Windows. #26193

merged 2 commits into from Apr 16, 2020
+2 −2

Conversation

@jdm
Copy link
Member

jdm commented Apr 15, 2020

This is required for building with the latest versions of Visual Studio 2019.
@jdm
Upgrade clang to 9.0 on Windows.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c32b1ac
@highfive
Copy link

highfive commented Apr 15, 2020

Heads up! This PR modifies the following files:
@jdm
Copy link
Member Author

jdm commented Apr 15, 2020

r? @asajeffrey
@highfive highfive assigned asajeffrey and unassigned paulrouget Apr 15, 2020
@asajeffrey
Copy link
Member

asajeffrey commented Apr 16, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2020

📌 Commit c32b1ac has been approved by asajeffrey
bors-servo added a commit that referenced this pull request Apr 16, 2020
@bors-servo
Auto merge of #26193 - servo:jdm-patch-36, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1e23ecd 
Upgrade clang to 9.0 on Windows.

This is required for building with the latest versions of Visual Studio 2019.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2020

⌛ Testing commit c32b1ac with merge 1e23ecd...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2020

💔 Test failed - status-taskcluster
@jdm
Update required clang-format version.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3a8af93
@jdm
Copy link
Member Author

jdm commented Apr 16, 2020

@bors-servo try=windows
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2020

⌛ Trying commit 3a8af93 with merge b0b8871...
bors-servo added a commit that referenced this pull request Apr 16, 2020
@bors-servo
Auto merge of #26193 - servo:jdm-patch-36, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b0b8871 
Upgrade clang to 9.0 on Windows.

This is required for building with the latest versions of Visual Studio 2019.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2020

☀️ Test successful - status-taskcluster
State: approved= try=True
@jdm
Copy link
Member Author

jdm commented Apr 16, 2020 •
edited

@bors-servo r=asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2020

📌 Commit 3a8af93 has been approved by asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2020

⌛ Testing commit 3a8af93 with merge 8f49c7f...
bors-servo added a commit that referenced this pull request Apr 16, 2020
@bors-servo
Auto merge of #26193 - servo:jdm-patch-36, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8f49c7f 
Upgrade clang to 9.0 on Windows.

This is required for building with the latest versions of Visual Studio 2019.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2020

💔 Test failed - status-taskcluster
@ferjm
Copy link
Member

ferjm commented Apr 16, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2020

⌛ Testing commit 3a8af93 with merge 351e5ef...
bors-servo added a commit that referenced this pull request Apr 16, 2020
@bors-servo
Auto merge of #26193 - servo:jdm-patch-36, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
351e5ef 
Upgrade clang to 9.0 on Windows.

This is required for building with the latest versions of Visual Studio 2019.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2020

💔 Test failed - status-taskcluster
@ferjm
Copy link
Member

ferjm commented Apr 16, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2020

⌛ Testing commit 3a8af93 with merge 6f07997...
bors-servo added a commit that referenced this pull request Apr 16, 2020
@bors-servo
Auto merge of #26193 - servo:jdm-patch-36, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6f07997 
Upgrade clang to 9.0 on Windows.

This is required for building with the latest versions of Visual Studio 2019.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2020

💔 Test failed - status-taskcluster
@ferjm
Copy link
Member

ferjm commented Apr 16, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2020

⌛ Testing commit 3a8af93 with merge c0d67f7...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2020

☀️ Test successful - status-taskcluster
Approved by: asajeffrey
Pushing c0d67f7 to master...
@bors-servo bors-servo merged commit c0d67f7 into master Apr 16, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo deleted the jdm-patch-36 branch Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asajeffrey asajeffrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@jdm @highfive @asajeffrey @bors-servo @ferjm @paulrouget
You can’t perform that action at this time.