Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump all UWP logging output to a file #26196

Merged
merged 1 commit into from Apr 17, 2020
Merged

Dump all UWP logging output to a file #26196

merged 1 commit into from Apr 17, 2020

Conversation

@jdm
Copy link
Member

jdm commented Apr 15, 2020

These changes ensure that we keep getting debug output in the VS output window, but we also write each message to a file in the app's local data directory. These changes also extend the C API a bit to support more generic logging facilities, removing some of the Windows-specific nature of the VSLogger. Fixes part of #23813.

@jdm jdm force-pushed the jdm:stdout-log branch 2 times, most recently from e731478 to 9fdb420 Apr 16, 2020
@jdm jdm marked this pull request as ready for review Apr 16, 2020
@jdm
Copy link
Member Author

jdm commented Apr 16, 2020

This is ready for review. I gated the log output on debug builds by default to avoid the risk of hurting perf by writing to a file.

Copy link
Member

Manishearth left a comment

@Manishearth
Copy link
Member

Manishearth commented Apr 16, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2020

📌 Commit 9fdb420 has been approved by Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2020

Testing commit 9fdb420 with merge b4aea41...

bors-servo added a commit that referenced this pull request Apr 16, 2020
Dump all UWP logging output to a file

These changes ensure that we keep getting debug output in the VS output window, but we also write each message to a file in the app's local data directory. These changes also extend the C API a bit to support more generic logging facilities, removing some of the Windows-specific nature of the VSLogger. Fixes part of #23813.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2020

💔 Test failed - status-taskcluster

@jdm jdm force-pushed the jdm:stdout-log branch from 9fdb420 to b1b4b5e Apr 16, 2020
@jdm
Copy link
Member Author

jdm commented Apr 16, 2020

@bors-servo r=Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2020

📌 Commit b1b4b5e has been approved by Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2020

Testing commit b1b4b5e with merge cc78171...

bors-servo added a commit that referenced this pull request Apr 16, 2020
Dump all UWP logging output to a file

These changes ensure that we keep getting debug output in the VS output window, but we also write each message to a file in the app's local data directory. These changes also extend the C API a bit to support more generic logging facilities, removing some of the Windows-specific nature of the VSLogger. Fixes part of #23813.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 17, 2020

💔 Test failed - status-taskcluster

@Manishearth
Copy link
Member

Manishearth commented Apr 17, 2020

 unused variable: `handler`
  --> ports/libsimpleservo/capi/src/lib.rs:70:27
   |
70 | fn redirect_stdout_stderr(handler: LogHandlerFn) -> Result<(), String> {
   |                           ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_handler`
   |
   = note: `-D unused-variables` implied by `-D warnings
@jdm jdm force-pushed the jdm:stdout-log branch from b1b4b5e to 285d97a Apr 17, 2020
@jdm jdm force-pushed the jdm:stdout-log branch from 285d97a to 6a73c5b Apr 17, 2020
@jdm
Copy link
Member Author

jdm commented Apr 17, 2020

@bors-servo r=Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Apr 17, 2020

📌 Commit 6a73c5b has been approved by Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Apr 17, 2020

Testing commit 6a73c5b with merge aa37904...

@bors-servo
Copy link
Contributor

bors-servo commented Apr 17, 2020

☀️ Test successful - status-taskcluster
Approved by: Manishearth
Pushing aa37904 to master...

@bors-servo bors-servo merged commit aa37904 into servo:master Apr 17, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@jdm jdm mentioned this pull request Apr 20, 2020
4 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.