Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedupe the dirs dependency #26223

Merged
merged 1 commit into from Apr 19, 2020
Merged

Dedupe the dirs dependency #26223

merged 1 commit into from Apr 19, 2020

Conversation

@Eijebong
Copy link
Member

Eijebong commented Apr 19, 2020

No description provided.

@Eijebong
Dedupe the dirs dependency
Loading status checks…
3c89566
@nox
Copy link
Member

nox commented Apr 19, 2020

POGGERS

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 19, 2020

📌 Commit 3c89566 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Apr 19, 2020

⌛ Testing commit 3c89566 with merge e9d809b...
bors-servo added a commit that referenced this pull request Apr 19, 2020
@bors-servo
Auto merge of #26223 - Eijebong:dirs, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e9d809b 
Dedupe the dirs dependency
@bors-servo
Copy link
Contributor

bors-servo commented Apr 19, 2020

💔 Test failed - status-taskcluster
@Eijebong
Copy link
Member Author

Eijebong commented Apr 19, 2020 

1 unexpected results that are NOT known-intermittents:
  ▶ CRASH [expected PASS] /_mozilla/css/text_node_opacity.html
  │ 
  │ error: XDG_RUNTIME_DIR not set in the environment.
  │ libEGL warning: No hardware driver found, falling back to software rendering
  │ Shutting down the Constellation after generating an output file or exit flag specified
  │ error: XDG_RUNTIME_DIR not set in the environment.
  │ libEGL warning: No hardware driver found, falling back to software rendering
  │ Shutting down the Constellation after generating an output file or exit flag specified
  │ Stack trace for thread "LayoutThread PipelineId { namespace_id: PipelineNamespaceId(1), index: PipelineIndex(1) }"
  └ stack backtrace:

Uh ? Could this be related ? If so why is it the only failing one ?
@Eijebong
Copy link
Member Author

Eijebong commented Apr 19, 2020

Well the test passes locally even if I unset XDG_RUNTIME_DIR before
@jdm
Copy link
Member

jdm commented Apr 19, 2020

That's probably #26129.

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 19, 2020

⌛ Testing commit 3c89566 with merge 240b58a...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 19, 2020

☀️ Test successful - status-taskcluster
Approved by: nox
Pushing 240b58a to master...
@bors-servo bors-servo merged commit 240b58a into servo:master Apr 19, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Eijebong @nox @bors-servo @jdm @highfive
You can’t perform that action at this time.