Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python binary to run multiprocess tests. #26229

Merged
merged 3 commits into from Apr 20, 2020
Merged

Use python binary to run multiprocess tests. #26229

merged 3 commits into from Apr 20, 2020

Conversation

@jdm
Copy link
Member

jdm commented Apr 20, 2020

The python2 binary doesn't exist in the path on macOS. This change uses an existing python2 on macOS and whatever the default python version is on linux.
@jdm
Use python binary to run multiprocess tests.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2777134
@jdm jdm mentioned this pull request Apr 20, 2020
Closed
0 of 5 tasks complete
@SimonSapin
Copy link
Member

SimonSapin commented Apr 20, 2020

LGTM, but if this python2 fails now how did it work before?
@jdm
Copy link
Member Author

jdm commented Apr 20, 2020

It never worked. I think possibly the | cat on the end of the line suppresses the error so CI doesn't report a failure.
@SimonSapin
Copy link
Member

SimonSapin commented Apr 20, 2020

Please also add -o pipefail (before -c) at these two locations, in order to catch such failures:

servo/etc/taskcluster/decisionlib.py

Line 752 in 5f5643e

"/bin/bash", "--login", "-x", "-e", "-c",

servo/etc/taskcluster/decisionlib.py

Line 688 in 5f5643e

"/bin/bash", "--login", "-x", "-e", "-c",

@jdm
Propagate pipe failure.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
34c3030
@jdm
Copy link
Member Author

jdm commented Apr 20, 2020

@bors-servo try
bors-servo added a commit that referenced this pull request Apr 20, 2020
@bors-servo
Auto merge of #26229 - servo:jdm-patch-36, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e5eed8d 
Use python binary to run multiprocess tests.

The python2 binary doesn't exist in the path on macOS. This change uses an existing python2 on macOS and whatever the default python version is on linux.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2020

⌛ Trying commit 34c3030 with merge e5eed8d...
@SimonSapin
SimonSapin approved these changes Apr 20, 2020
View changes
Copy link
Member

SimonSapin left a comment

r+ assuming try looks good
etc/taskcluster/decision_task.py
@@ -614,7 +614,7 @@ def wpt_chunks(platform, make_chunk_task, build_task, total_chunks, processes,
# https://github.com/servo/servo/issues/22438
if this_chunk == 0:
task.with_script("""
time python2 ./mach test-wpt --release --binary-arg=--multiprocess \
time python ./mach test-wpt --release --binary-arg=--multiprocess \

This comment has been minimized.

Sign in to view
Copy link
@SimonSapin

SimonSapin Apr 20, 2020

Member

time ./mach (relying on shebang, like in other uses of mach commands) should also work, but this is fine.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2020

💔 Test failed - status-taskcluster
@servo-wpt-sync servo-wpt-sync mentioned this pull request Apr 20, 2020
Merged
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Apr 20, 2020

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#23120.
@jdm
Pass a protocol to the TimedRunner constructor instead of a session.
Loading status checks…
a3587e6
@jdm jdm force-pushed the jdm-patch-36 branch from 2102ab5 to a3587e6 Apr 20, 2020
@jdm
Copy link
Member Author

jdm commented Apr 20, 2020

@bors-servo r=SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2020

📌 Commit a3587e6 has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2020

⌛ Testing commit a3587e6 with merge d0c2ec6...
bors-servo added a commit that referenced this pull request Apr 20, 2020
@bors-servo
Auto merge of #26229 - servo:jdm-patch-36, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d0c2ec6 
Use python binary to run multiprocess tests.

The python2 binary doesn't exist in the path on macOS. This change uses an existing python2 on macOS and whatever the default python version is on linux.
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Apr 20, 2020

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#23120.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Apr 20, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2020

⌛ Testing commit a3587e6 with merge 7f5faac...
bors-servo added a commit that referenced this pull request Apr 20, 2020
@bors-servo
Auto merge of #26229 - servo:jdm-patch-36, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7f5faac 
Use python binary to run multiprocess tests.

The python2 binary doesn't exist in the path on macOS. This change uses an existing python2 on macOS and whatever the default python version is on linux.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Apr 20, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2020

⌛ Testing commit a3587e6 with merge 4c8413d...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2020

☀️ Test successful - status-taskcluster
Approved by: SimonSapin
Pushing 4c8413d to master...
@bors-servo bors-servo merged commit 4c8413d into master Apr 20, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo deleted the jdm-patch-36 branch Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonSapin SimonSapin

Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jdm @SimonSapin @bors-servo @servo-wpt-sync @highfive
You can’t perform that action at this time.