Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python binary to run multiprocess tests. #26229

Merged
merged 3 commits into from Apr 20, 2020
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -614,7 +614,7 @@ def wpt_chunks(platform, make_chunk_task, build_task, total_chunks, processes,
# https://github.com/servo/servo/issues/22438
if this_chunk == 0:
task.with_script("""
time python2 ./mach test-wpt --release --binary-arg=--multiprocess \
time python ./mach test-wpt --release --binary-arg=--multiprocess \

This comment has been minimized.

Copy link
@SimonSapin

SimonSapin Apr 20, 2020

Member

time ./mach (relying on shebang, like in other uses of mach commands) should also work, but this is fine.

--processes $PROCESSES \
--log-raw test-wpt-mp.log \
--log-errorsummary wpt-mp-errorsummary.log \
@@ -685,7 +685,7 @@ def build_command(self):
# So concatenate scripts and use a single `bash` command instead.
return [
[
"/bin/bash", "--login", "-x", "-e", "-c",
"/bin/bash", "--login", "-x", "-e", "-o", "pipefail", "-c",
deindent("\n".join(self.scripts))
]
]
@@ -749,7 +749,7 @@ def build_worker_payload(self):
"image": self.docker_image,
"maxRunTime": self.max_run_time_minutes * 60,
"command": [
"/bin/bash", "--login", "-x", "-e", "-c",
"/bin/bash", "--login", "-x", "-e", "-o", "pipefail", "-c",
deindent("\n".join(self.scripts))
],
}
[]
],
"executorservodriver.py": [
"425f40223f77535d4ea34d75790e8facce30f77a",
"2e47a22a9c92b4caada29db358c08104793d2770",
[]
],
"executorwebdriver.py": [
@@ -277,7 +277,7 @@ def screenshot(self, test, viewport_size, dpi):

return ServoWebDriverRun(self.logger,
self._screenshot,
self.protocol.session,
self.protocol,
self.test_url(test),
timeout,
self.extra_timeout).run()
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.