Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSMesa is no longer a build dependency #26237

Merged
merged 2 commits into from Apr 21, 2020
Merged

OSMesa is no longer a build dependency #26237

merged 2 commits into from Apr 21, 2020

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Apr 20, 2020

Since #25853
SimonSapin added 2 commits Apr 20, 2020
@SimonSapin
Remove use of `webrender::RendererKind`
bbed751 
It appears to be unused since 2017 with servo/webrender#1587
CC https://bugzilla.mozilla.org/show_bug.cgi?id=1631579
@SimonSapin
OSMesa is no longer a build dependency
Loading status checks…
f864697 
Since #25853
@highfive
Copy link

highfive commented Apr 20, 2020

Heads up! This PR modifies the following files:
@SimonSapin
Copy link
Member Author

SimonSapin commented Apr 20, 2020

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2020

⌛ Trying commit f864697 with merge fab1129...
bors-servo added a commit that referenced this pull request Apr 20, 2020
@bors-servo
Auto merge of #26237 - servo:unosmesa, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fab1129 
OSMesa is no longer a build dependency

Since #25853
@dralley
Copy link
Contributor

dralley commented Apr 20, 2020

Several of these issues can probably be cleaned up as well: https://github.com/servo/servo/issues?q=is%3Aissue+is%3Aopen+osmesa
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2020

☀️ Test successful - status-taskcluster
State: approved= try=True
@asajeffrey
Copy link
Member

asajeffrey commented Apr 20, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2020

📌 Commit f864697 has been approved by asajeffrey
@highfive highfive assigned asajeffrey and unassigned Manishearth Apr 20, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2020

⌛ Testing commit f864697 with merge c838538...
bors-servo added a commit that referenced this pull request Apr 20, 2020
@bors-servo
Auto merge of #26237 - servo:unosmesa, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c838538 
OSMesa is no longer a build dependency

Since #25853
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2020

💔 Test failed - status-taskcluster
@SimonSapin
Copy link
Member Author

SimonSapin commented Apr 20, 2020

@bors-servo retry #26192
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2020

⌛ Testing commit f864697 with merge a8fcd2b...
bors-servo added a commit that referenced this pull request Apr 20, 2020
@bors-servo
Auto merge of #26237 - servo:unosmesa, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a8fcd2b 
OSMesa is no longer a build dependency

Since #25853
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Apr 20, 2020

@bors-servo retry
@dralley dralley mentioned this pull request Apr 20, 2020
Closed
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2020

⌛ Testing commit f864697 with merge 371c417...
bors-servo added a commit that referenced this pull request Apr 20, 2020
@bors-servo
Auto merge of #26237 - servo:unosmesa, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
371c417 
OSMesa is no longer a build dependency

Since #25853
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Apr 21, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2020

⌛ Testing commit f864697 with merge a5fe8f0...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2020

☀️ Test successful - status-taskcluster
Approved by: asajeffrey
Pushing a5fe8f0 to master...
@bors-servo bors-servo merged commit a5fe8f0 into master Apr 21, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo deleted the unosmesa branch Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asajeffrey asajeffrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@SimonSapin @highfive @bors-servo @dralley @asajeffrey @jdm @Manishearth
You can’t perform that action at this time.