Add support for canceling CSS transitions #26244

mrobinson · 2020-04-21T15:27:12Z

This change adds support for canceling CSS transitions when a property is
no longer transitionable. Support for canceling and replacing CSS
transitions when the end value changes is still pending. This change
also takes advantage of updating the constellation message to fix a bug
where transition events could be sent for closed pipelines.

Fixes #15079.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #15079.

There are tests for these changes OR
These changes do not require tests because ___

highfive · 2020-04-21T15:27:18Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/webidls/EventHandler.webidl, components/script/dom/macros.rs, components/script/script_thread.rs
@KiChjang: components/script/dom/webidls/EventHandler.webidl, components/script/dom/macros.rs, components/script/script_thread.rs, components/script_traits/lib.rs
@emilio: components/style/context.rs, components/layout/animation.rs, components/style/animation.rs, components/style/matching.rs

jdm · 2020-04-21T16:33:17Z

@bors-servo try=wpt

bors-servo · 2020-04-21T16:44:57Z

⌛ Trying commit 110ed92 with merge cee29f4...


        Auto merge of #26244 - mrobinson:animation-cancel, r=<try>

Add support for canceling CSS transitions This change adds support for canceling CSS transitions when a property is no longer transitionable. Support for canceling and replacing CSS transitions when the end value changes is still pending. This change also takes advantage of updating the constellation message to fix a bug where transition events could be sent for closed pipelines. Fixes #15079.  ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #15079.  - [x] There are tests for these changes OR - [ ] These changes do not require tests because ___

bors-servo · 2020-04-21T17:27:36Z

💔 Test failed - status-taskcluster

jdm · 2020-04-21T17:34:58Z

Since this exposes a new DOM event, it seems surprising that no tests demonstrate a change in behaviour. Maybe add a test that shows that these changes are working?

servo-wpt-sync · 2020-04-22T11:05:05Z

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#23166.

servo-wpt-sync · 2020-04-22T11:05:41Z

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#23166.

mrobinson · 2020-04-22T11:09:49Z

It seems like the web-platform-tests have a few tests which detect transitioncancel when an element becomes display: none or when it's removed from the DOM, but it doesn't seem like there are any testing when a property is no longer transitionable. I've done two things:

Added a test which verifies this case.
Modified my change to handle the element becoming display: none causing one more WPT test to pass.

The rest of the tests that test transitioncancel events seem to rely on other features that we don't implement yet (such as transitionrun events or DOM removal). Hopefully these will start passing as we implement more events.

I'm not sure what the procedure is when adding new WPT tests, but I'm happy to work through that.

(the @servo-wpt-sync bot is really cool!)

mrobinson · 2020-04-22T11:10:10Z

@bors-servo try=wpt

bors-servo · 2020-04-22T11:10:17Z

⌛ Trying commit a02b13d with merge 1114a85...


        Auto merge of #26244 - mrobinson:animation-cancel, r=<try>

Add support for canceling CSS transitions This change adds support for canceling CSS transitions when a property is no longer transitionable. Support for canceling and replacing CSS transitions when the end value changes is still pending. This change also takes advantage of updating the constellation message to fix a bug where transition events could be sent for closed pipelines. Fixes #15079.  ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #15079.  - [x] There are tests for these changes OR - [ ] These changes do not require tests because ___

bors-servo · 2020-04-22T11:53:52Z

☀️ Test successful - status-taskcluster
State: approved= try=True

jdm · 2020-04-22T12:15:49Z

{"path": "css/css-transitions/transitioncancel-002.html", "message": "Test-file line has a `console.*(...)` call", "lineno": 29, "rule": "CONSOLE"}
{"path": "css/css-transitions/transitioncancel-002.html", "message": "setTimeout used", "lineno": 39, "rule": "SET TIMEOUT"}
{"path": "css/css-transitions/transitioncancel-002.html", "message": "setTimeout used", "lineno": 44, "rule": "SET TIMEOUT"}

jdm

looks good! don't forget to run mach update-manifest after changing the test file.

jdm · 2020-04-22T12:20:30Z

tests/wpt/web-platform-tests/css/css-transitions/transitioncancel-002.html

+  getComputedStyle(div).backgroundColor;
+
+  // Remove the transitioning property from transition-property asynchronously.
+  setTimeout(() => { div.style.transitionProperty = 'none'; }, 0);


use t.step_timeout instead.

jdm · 2020-04-22T12:20:30Z

tests/wpt/web-platform-tests/css/css-transitions/transitioncancel-002.html

+  await eventWatcher.wait_for('transitioncancel');
+
+  // There should be no transitionend events received.
+  await new Promise(resolve => setTimeout(resolve, 300));


t.step_timeout

jdm · 2020-04-22T12:20:30Z

tests/wpt/web-platform-tests/css/css-transitions/transitioncancel-002.html

+  // Attach event listeners
+  const eventWatcher = new EventWatcher(t, div, ['transitioncancel']);
+  div.addEventListener('transitionend', t.step_func((event) => {
+    console.log(event);


remove this to satisfy the linter.

servo-wpt-sync · 2020-04-22T12:25:56Z

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#23166.

jdm · 2020-04-22T12:29:11Z

@bors-servo r+

bors-servo · 2020-04-22T12:29:12Z

📌 Commit 88a1f6c has been approved by jdm


        Auto merge of #26244 - mrobinson:animation-cancel, r=jdm

Add support for canceling CSS transitions This change adds support for canceling CSS transitions when a property is no longer transitionable. Support for canceling and replacing CSS transitions when the end value changes is still pending. This change also takes advantage of updating the constellation message to fix a bug where transition events could be sent for closed pipelines. Fixes #15079.  ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #15079.  - [x] There are tests for these changes OR - [ ] These changes do not require tests because ___

bors-servo · 2020-04-22T17:02:40Z

⌛ Testing commit 453b252 with merge 61d5b47...

bors-servo · 2020-04-22T17:43:34Z

💔 Test failed - status-taskcluster

jdm · 2020-04-22T17:52:37Z

@bors-servo retry

#25522

bors-servo · 2020-04-22T18:04:59Z

⌛ Testing commit 453b252 with merge ccdf2d7...


        Auto merge of #26244 - mrobinson:animation-cancel, r=jdm

Add support for canceling CSS transitions This change adds support for canceling CSS transitions when a property is no longer transitionable. Support for canceling and replacing CSS transitions when the end value changes is still pending. This change also takes advantage of updating the constellation message to fix a bug where transition events could be sent for closed pipelines. Fixes #15079.  ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #15079.  - [x] There are tests for these changes OR - [ ] These changes do not require tests because ___

bors-servo · 2020-04-22T18:49:16Z

💔 Test failed - status-taskcluster

jdm · 2020-04-22T18:57:42Z

@bors-servo retry

#25513

bors-servo · 2020-04-22T19:34:09Z

⌛ Testing commit 453b252 with merge 610991b...

bors-servo · 2020-04-22T19:51:33Z

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 610991b to master...


        Bug 1632363 - Add support for canceling CSS transitions. r=emilio

This change adds support for canceling CSS transitions when a property is no longer transitionable or when an element becomes styled with display:none. Support for canceling and replacing CSS transitions when the end value changes is still pending. This change also takes advantage of updating the constellation message to fix a bug where transition events could be sent for closed pipelines. Cherry-picked from servo/servo#26244 (though this is not part of the Gecko build).


        Bug 1632363 - Add support for canceling CSS transitions. r=emilio

This change adds support for canceling CSS transitions when a property is no longer transitionable or when an element becomes styled with display:none. Support for canceling and replacing CSS transitions when the end value changes is still pending. This change also takes advantage of updating the constellation message to fix a bug where transition events could be sent for closed pipelines. Cherry-picked from servo/servo#26244 (though this is not part of the Gecko build).


        Bug 1632363 - Add support for canceling CSS transitions. r=emilio

This change adds support for canceling CSS transitions when a property is no longer transitionable or when an element becomes styled with display:none. Support for canceling and replacing CSS transitions when the end value changes is still pending. This change also takes advantage of updating the constellation message to fix a bug where transition events could be sent for closed pipelines. Cherry-picked from servo/servo#26244 (though this is not part of the Gecko build). UltraBlame original commit: 612b48f120bac79925d232386e6fe12bb833b027


        Bug 1632363 - Add support for canceling CSS transitions. r=emilio

This change adds support for canceling CSS transitions when a property is no longer transitionable or when an element becomes styled with display:none. Support for canceling and replacing CSS transitions when the end value changes is still pending. This change also takes advantage of updating the constellation message to fix a bug where transition events could be sent for closed pipelines. Cherry-picked from servo/servo#26244 (though this is not part of the Gecko build). UltraBlame original commit: 612b48f120bac79925d232386e6fe12bb833b027


        Bug 1632363 - Add support for canceling CSS transitions. r=emilio

This change adds support for canceling CSS transitions when a property is no longer transitionable or when an element becomes styled with display:none. Support for canceling and replacing CSS transitions when the end value changes is still pending. This change also takes advantage of updating the constellation message to fix a bug where transition events could be sent for closed pipelines. Cherry-picked from servo/servo#26244 (though this is not part of the Gecko build). UltraBlame original commit: 612b48f120bac79925d232386e6fe12bb833b027

mrobinson requested review from jdm and emilio Apr 21, 2020

highfive assigned asajeffrey Apr 21, 2020

highfive added the S-awaiting-review label Apr 21, 2020

jdm approved these changes Apr 21, 2020

View changes

highfive added the S-tests-failed label Apr 21, 2020

jdm added the S-needs-tests label Apr 21, 2020

mrobinson force-pushed the mrobinson:animation-cancel branch from 110ed92 to 0107a44 Apr 22, 2020

highfive removed the S-tests-failed label Apr 22, 2020

servo-wpt-sync mentioned this pull request Apr 22, 2020

Add support for canceling CSS transitions web-platform-tests/wpt#23166

Merged

mrobinson force-pushed the mrobinson:animation-cancel branch from 0107a44 to a02b13d Apr 22, 2020

jdm requested changes Apr 22, 2020

View changes

mrobinson force-pushed the mrobinson:animation-cancel branch from a02b13d to 88a1f6c Apr 22, 2020

highfive added S-awaiting-merge and removed S-awaiting-review labels Apr 22, 2020

highfive added S-tests-failed and removed S-awaiting-merge labels Apr 22, 2020

highfive added S-awaiting-merge and removed S-tests-failed labels Apr 22, 2020

highfive added S-tests-failed and removed S-awaiting-merge labels Apr 22, 2020

highfive added S-awaiting-merge and removed S-tests-failed labels Apr 22, 2020

bors-servo merged commit 610991b into servo:master Apr 22, 2020
2 checks passed

2 checks passed

Community-TC (pull_request) TaskGroup: success
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Apr 22, 2020

mrobinson deleted the mrobinson:animation-cancel branch Apr 22, 2020

mrobinson mentioned this pull request Apr 27, 2020

Improvements to the CSS Transitions and Animations implementation #26328

Closed

20 of 21 tasks complete

servo / servo

Add support for canceling CSS transitions #26244

Add support for canceling CSS transitions #26244

mrobinson commented Apr 21, 2020

highfive commented Apr 21, 2020

jdm commented Apr 21, 2020

bors-servo commented Apr 21, 2020

bors-servo commented Apr 21, 2020

jdm commented Apr 21, 2020

servo-wpt-sync commented Apr 22, 2020

servo-wpt-sync commented Apr 22, 2020

mrobinson commented Apr 22, 2020

mrobinson commented Apr 22, 2020

bors-servo commented Apr 22, 2020

bors-servo commented Apr 22, 2020

jdm commented Apr 22, 2020

jdm left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

servo-wpt-sync commented Apr 22, 2020

jdm commented Apr 22, 2020

bors-servo commented Apr 22, 2020

bors-servo commented Apr 22, 2020

bors-servo commented Apr 22, 2020

jdm commented Apr 22, 2020

bors-servo commented Apr 22, 2020

bors-servo commented Apr 22, 2020

jdm commented Apr 22, 2020

bors-servo commented Apr 22, 2020

bors-servo commented Apr 22, 2020

servo / servo

Join GitHub today

Add support for canceling CSS transitions #26244

Add support for canceling CSS transitions #26244

Conversation

mrobinson commented Apr 21, 2020

highfive commented Apr 21, 2020

jdm commented Apr 21, 2020

bors-servo commented Apr 21, 2020

bors-servo commented Apr 21, 2020

jdm commented Apr 21, 2020

servo-wpt-sync commented Apr 22, 2020

servo-wpt-sync commented Apr 22, 2020

mrobinson commented Apr 22, 2020

mrobinson commented Apr 22, 2020

bors-servo commented Apr 22, 2020

bors-servo commented Apr 22, 2020

jdm commented Apr 22, 2020

jdm left a comment

This comment has been minimized.

jdm Apr 22, 2020

This comment has been minimized.

jdm Apr 22, 2020

This comment has been minimized.

jdm Apr 22, 2020

servo-wpt-sync commented Apr 22, 2020

jdm commented Apr 22, 2020

bors-servo commented Apr 22, 2020

bors-servo commented Apr 22, 2020

bors-servo commented Apr 22, 2020

jdm commented Apr 22, 2020

bors-servo commented Apr 22, 2020

bors-servo commented Apr 22, 2020

jdm commented Apr 22, 2020

bors-servo commented Apr 22, 2020

bors-servo commented Apr 22, 2020