Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dummy implementation of contentEditable #26253

Merged
merged 1 commit into from Apr 22, 2020
Merged

Add a dummy implementation of contentEditable #26253

merged 1 commit into from Apr 22, 2020

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Apr 21, 2020

Add a dummy implementation of contentEditable.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because the existing wpt tests should do
@highfive
Copy link

highfive commented Apr 21, 2020

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/htmlelement.rs, components/script/dom/webidls/ElementContentEditable.webidl
@highfive
Copy link

highfive commented Apr 21, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@asajeffrey
Copy link
Member Author

asajeffrey commented Apr 21, 2020

This is still a draft, as I expect the test expectations to change. @bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2020

⌛ Trying commit 3e60ef7 with merge 49d850f...
bors-servo added a commit that referenced this pull request Apr 21, 2020
@bors-servo
Auto merge of #26253 - asajeffrey:script-dummy-content-editble, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
49d850f 
Add a dummy implementation of contentEditable

<!-- Please describe your changes on the following line: -->

Add a dummy implementation of `contentEditable`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because the existing wpt tests should do

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@asajeffrey
Copy link
Member Author

asajeffrey commented Apr 21, 2020

This is a teeny tiny step towards #12776.

Hopefully it'll fix #26252.
@asajeffrey
Copy link
Member Author

asajeffrey commented Apr 21, 2020

It does seem to fix #26252, yay I can do slide presentations in servo.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2020

💔 Test failed - status-taskcluster
@asajeffrey
Copy link
Member Author

asajeffrey commented Apr 22, 2020

Ah, just some FAILs that are now PASS.
@asajeffrey
Add a dummy implementation of contentEditable
Loading status checks…
c00eb62
@asajeffrey asajeffrey force-pushed the asajeffrey:script-dummy-content-editble branch from 3e60ef7 to c00eb62 Apr 22, 2020
@asajeffrey asajeffrey marked this pull request as ready for review Apr 22, 2020
@asajeffrey
Copy link
Member Author

asajeffrey commented Apr 22, 2020

r? @jdm
@highfive highfive assigned jdm and unassigned paulrouget Apr 22, 2020
@jdm
Copy link
Member

jdm commented Apr 22, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 22, 2020

📌 Commit c00eb62 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Apr 22, 2020

⌛ Testing commit c00eb62 with merge 1b1635a...
bors-servo added a commit that referenced this pull request Apr 22, 2020
@bors-servo
Auto merge of #26253 - asajeffrey:script-dummy-content-editble, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1b1635a 
Add a dummy implementation of contentEditable

<!-- Please describe your changes on the following line: -->

Add a dummy implementation of `contentEditable`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because the existing wpt tests should do

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 22, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Apr 22, 2020

@bors-servo retry
bors-servo added a commit that referenced this pull request Apr 22, 2020
@bors-servo
Auto merge of #26253 - asajeffrey:script-dummy-content-editble, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d3ef8ba 
Add a dummy implementation of contentEditable

<!-- Please describe your changes on the following line: -->

Add a dummy implementation of `contentEditable`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because the existing wpt tests should do

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 22, 2020

⌛ Testing commit c00eb62 with merge d3ef8ba...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 22, 2020

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Apr 22, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 22, 2020

⌛ Testing commit c00eb62 with merge 933bcfe...
bors-servo added a commit that referenced this pull request Apr 22, 2020
@bors-servo
Auto merge of #26253 - asajeffrey:script-dummy-content-editble, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
933bcfe 
Add a dummy implementation of contentEditable

<!-- Please describe your changes on the following line: -->

Add a dummy implementation of `contentEditable`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because the existing wpt tests should do

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 22, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Apr 22, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 22, 2020

⌛ Testing commit c00eb62 with merge 84fe99b...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 22, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 84fe99b to master...
@bors-servo bors-servo merged commit 84fe99b into servo:master Apr 22, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@asajeffrey asajeffrey mentioned this pull request Apr 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
A-content/script
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@asajeffrey @highfive @bors-servo @jdm @CYBAI @paulrouget
You can’t perform that action at this time.