Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced failible boolean with an enum #26289

Merged
merged 1 commit into from Apr 24, 2020
Merged

Replaced failible boolean with an enum #26289

merged 1 commit into from Apr 24, 2020

Conversation

@he4d
Copy link
Contributor

he4d commented Apr 23, 2020

Replaced the boolean fallible argument of some WebGL object methods with the new enum Operation { Fallible, Infallible } that was added to the webglrenderingcontext. This improves the readability of that methods.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #26047 (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because the issue says so
@he4d
Replaced failible boolean with an enum
Loading status checks…
9c343fc
@highfive
Copy link

highfive commented Apr 23, 2020

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @nox (or someone else) soon.
@highfive
Copy link

highfive commented Apr 23, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webglvertexarrayobject.rs, components/script/dom/webglvertexarrayobjectoes.rs, components/script/dom/webglsampler.rs, components/script/dom/vertexarrayobject.rs, components/script/dom/webglframebuffer.rs and 10 more
  • @KiChjang: components/script/dom/webglvertexarrayobject.rs, components/script/dom/webglvertexarrayobjectoes.rs, components/script/dom/webglsampler.rs, components/script/dom/vertexarrayobject.rs, components/script/dom/webglframebuffer.rs and 10 more
@highfive
Copy link

highfive commented Apr 23, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Apr 23, 2020

@bors-servo r+
Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Apr 23, 2020

📌 Commit 9c343fc has been approved by jdm
@highfive highfive assigned jdm and unassigned nox Apr 23, 2020
bors-servo added a commit that referenced this pull request Apr 23, 2020
@bors-servo
Auto merge of #26289 - he4d:master, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
db777a4 
Replaced failible boolean with an enum

<!-- Please describe your changes on the following line: -->
Replaced the boolean `fallible` argument of some WebGL object methods with the new `enum Operation { Fallible, Infallible }` that was added to the `webglrenderingcontext`. This improves the readability of that methods.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #26047 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because the issue says so

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 23, 2020

⌛ Testing commit 9c343fc with merge db777a4...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 23, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Apr 23, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2020

⌛ Testing commit 9c343fc with merge c251e0e...
bors-servo added a commit that referenced this pull request Apr 24, 2020
@bors-servo
Auto merge of #26289 - he4d:master, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c251e0e 
Replaced failible boolean with an enum

<!-- Please describe your changes on the following line: -->
Replaced the boolean `fallible` argument of some WebGL object methods with the new `enum Operation { Fallible, Infallible }` that was added to the `webglrenderingcontext`. This improves the readability of that methods.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #26047 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because the issue says so

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Apr 24, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2020

⌛ Testing commit 9c343fc with merge 9e9cc1f...
bors-servo added a commit that referenced this pull request Apr 24, 2020
@bors-servo
Auto merge of #26289 - he4d:master, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9e9cc1f 
Replaced failible boolean with an enum

<!-- Please describe your changes on the following line: -->
Replaced the boolean `fallible` argument of some WebGL object methods with the new `enum Operation { Fallible, Infallible }` that was added to the `webglrenderingcontext`. This improves the readability of that methods.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #26047 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because the issue says so

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Apr 24, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2020

⌛ Testing commit 9c343fc with merge 469e3d0...
bors-servo added a commit that referenced this pull request Apr 24, 2020
@bors-servo
Auto merge of #26289 - he4d:master, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
469e3d0 
Replaced failible boolean with an enum

<!-- Please describe your changes on the following line: -->
Replaced the boolean `fallible` argument of some WebGL object methods with the new `enum Operation { Fallible, Infallible }` that was added to the `webglrenderingcontext`. This improves the readability of that methods.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #26047 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because the issue says so

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2020

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Apr 24, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2020

⌛ Testing commit 9c343fc with merge 2522004...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 2522004 to master...
@bors-servo bors-servo merged commit 2522004 into servo:master Apr 24, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Replace `fallible` boolean arguments with an enum
6 participants
@he4d @highfive @jdm @bors-servo @CYBAI @nox
You can’t perform that action at this time.