Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for transitionrun events #26308

Merged
merged 1 commit into from Apr 25, 2020
Merged

Add support for transitionrun events #26308

merged 1 commit into from Apr 25, 2020

Conversation

@mrobinson
Copy link
Member

mrobinson commented Apr 24, 2020

These events are triggered as soon as a transition is added to the list
of running transitions. This will allow better test coverage while
reworking the transitions and animations processing model.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___
@mrobinson
Add support for transitionrun events
Loading status checks…
d386d6d 
These events are triggered as soon as a transition is added to the list
of running transitions. This will allow better test coverage while
reworking the transitions and animations processing model.
@mrobinson mrobinson requested review from jdm and emilio Apr 24, 2020
@highfive
Copy link

highfive commented Apr 24, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/EventHandler.webidl, components/script/dom/macros.rs, components/script/dom/event.rs, components/script/script_thread.rs
  • @KiChjang: components/script/dom/webidls/EventHandler.webidl, components/script/dom/macros.rs, components/script/dom/event.rs, components/script/script_thread.rs, components/script_traits/lib.rs
  • @emilio: components/layout/animation.rs
@jdm
jdm approved these changes Apr 24, 2020
View changes
Copy link
Member

jdm left a comment

i appreciate the "this is a bit goofy" comment.
@emilio
emilio approved these changes Apr 24, 2020
View changes
Copy link
Member

emilio left a comment

I only took a quick skim since josh has already r+'d, but this looks reasonable over-all. Thanks!
@jdm
Copy link
Member

jdm commented Apr 24, 2020

@bors-servo r=jdm,emilio
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2020

📌 Commit d386d6d has been approved by jdm,emilio
@highfive highfive assigned jdm and unassigned ferjm Apr 24, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2020

⌛ Testing commit d386d6d with merge fe71ab6...
bors-servo added a commit that referenced this pull request Apr 24, 2020
@bors-servo
Auto merge of #26308 - mrobinson:animation-events2, r=jdm,emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fe71ab6 
Add support for transitionrun events

These events are triggered as soon as a transition is added to the list
of running transitions. This will allow better test coverage while
reworking the transitions and animations processing model.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2020

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Apr 25, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2020

⌛ Testing commit d386d6d with merge 24414b1...
bors-servo added a commit that referenced this pull request Apr 25, 2020
@bors-servo
Auto merge of #26308 - mrobinson:animation-events2, r=jdm,emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
24414b1 
Add support for transitionrun events

These events are triggered as soon as a transition is added to the list
of running transitions. This will allow better test coverage while
reworking the transitions and animations processing model.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Apr 25, 2020

@bors-servo retry
#25513
@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2020

⌛ Testing commit d386d6d with merge 537e575...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm,emilio
Pushing 537e575 to master...
@bors-servo bors-servo merged commit 537e575 into servo:master Apr 25, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@mrobinson mrobinson deleted the mrobinson:animation-events2 branch Apr 27, 2020
@mrobinson mrobinson mentioned this pull request Apr 27, 2020
Closed
20 of 21 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

@emilio emilio

Assignees

@jdm jdm

Labels
A-layout/animations
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@mrobinson @highfive @jdm @bors-servo @CYBAI @emilio @ferjm
You can’t perform that action at this time.