Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide feedback when OpenXR can't start #26312

Merged
merged 3 commits into from Apr 25, 2020
Merged

Provide feedback when OpenXR can't start #26312

merged 3 commits into from Apr 25, 2020
+52 −26

Conversation

@jdm
Copy link
Member

jdm commented Apr 24, 2020

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #26213
  • These changes do not require tests because it's testing an edge case in an environment we can't test on CI
@highfive
Copy link

highfive commented Apr 24, 2020

Heads up! This PR modifies the following files:
@jdm
Copy link
Member Author

jdm commented Apr 24, 2020

Depends on servo/webxr#164.
@highfive
Copy link

highfive commented Apr 24, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member Author

jdm commented Apr 24, 2020

r? @Manishearth
@highfive highfive assigned Manishearth and unassigned nox Apr 24, 2020
@Manishearth
Manishearth approved these changes Apr 24, 2020
View changes
Copy link
Member

Manishearth left a comment

r=me either way
ports/libsimpleservo/api/src/lib.rs
Box::new(ContextMenuCallback(embedder_proxy)),
);
registry.register(discovery);
if openxr::create_instance().is_ok() {

This comment has been minimized.

Sign in to view
@Manishearth

Manishearth Apr 24, 2020

Member

Hmm, this would be nicer if we had the prompt when you attempt to enter immersive mode, IMO. Might need another error variant

This comment has been minimized.

Sign in to view
@jdm

jdm Apr 24, 2020

Author Member

I'll file a followup for that, since it requires a bunch more plumbing.
jdm added 3 commits Apr 24, 2020
@jdm
Report openxr failure at app startup.
2a0700e
@jdm
Ensure correct buttons are disabled when prompting in UWP.
d6ae56b
@jdm
Enable UWP logging in release builds with FirefoxRealityLogStdout env…
Loading status checks…
a5970ab 
… var.
@jdm jdm force-pushed the jdm:webxr-debug branch from 8e6fba3 to a5970ab Apr 24, 2020
@jdm jdm marked this pull request as ready for review Apr 24, 2020
@jdm
Copy link
Member Author

jdm commented Apr 24, 2020

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2020

📌 Commit a5970ab has been approved by Manishearth
@jdm jdm mentioned this pull request Apr 24, 2020
Open
bors-servo added a commit that referenced this pull request Apr 24, 2020
@bors-servo
Auto merge of #26312 - jdm:webxr-debug, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6c6d5e5 
Provide feedback when OpenXR can't start

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26213
- [x] These changes do not require tests because it's testing an edge case in an environment we can't test on CI
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2020

⌛ Testing commit a5970ab with merge 6c6d5e5...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Apr 24, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2020

⌛ Testing commit a5970ab with merge 91cbfbb...
bors-servo added a commit that referenced this pull request Apr 24, 2020
@bors-servo
Auto merge of #26312 - jdm:webxr-debug, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
91cbfbb 
Provide feedback when OpenXR can't start

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26213
- [x] These changes do not require tests because it's testing an edge case in an environment we can't test on CI
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Apr 25, 2020

@bors-servo retry
#25513
@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2020

⌛ Testing commit a5970ab with merge 8c73fb9...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2020

☀️ Test successful - status-taskcluster
Approved by: Manishearth
Pushing 8c73fb9 to master...
@bors-servo bors-servo merged commit 8c73fb9 into servo:master Apr 25, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Apr 25, 2020
Merged
3 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth

Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Provide embedder feedback if openxr backend isn't set up right
5 participants
@jdm @highfive @bors-servo @Manishearth @nox
You can’t perform that action at this time.