Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Cargo.toml cleanups #26319

Merged
merged 1 commit into from Apr 26, 2020
Merged

Some Cargo.toml cleanups #26319

merged 1 commit into from Apr 26, 2020

Conversation

@atouchet
Copy link
Contributor

atouchet commented Apr 25, 2020

Some Cargo.toml cleanups. Adapted from #26024.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___
@highfive
Copy link

highfive commented Apr 25, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/constellation/Cargo.toml, components/script/Cargo.toml
  • @cbrewster: components/constellation/Cargo.toml
  • @KiChjang: components/script/Cargo.toml
@highfive
Copy link

highfive commented Apr 25, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Apr 25, 2020

@bors-servo r+
Thanks!

@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2020

📌 Commit b5a3f01 has been approved by jdm

@highfive highfive assigned jdm and unassigned nox Apr 25, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2020

Testing commit b5a3f01 with merge bcdc555...

bors-servo added a commit that referenced this pull request Apr 25, 2020
Some Cargo.toml cleanups

<!-- Please describe your changes on the following line: -->
Some Cargo.toml cleanups. Adapted from #26024.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Apr 25, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2020

Testing commit b5a3f01 with merge 83771d0...

@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 83771d0 to master...

@bors-servo bors-servo merged commit 83771d0 into servo:master Apr 26, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@atouchet atouchet deleted the atouchet:cargo branch Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.