Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ParentNode's querySelectorAll on Document, DocumentFragment & Element #2632

Merged
merged 3 commits into from Jun 11, 2014
Merged

Implement ParentNode's querySelectorAll on Document, DocumentFragment & Element #2632

merged 3 commits into from Jun 11, 2014

Conversation

@brunoabinader
Copy link
Contributor

brunoabinader commented Jun 10, 2014

Spec:
http://dom.spec.whatwg.org/#dom-parentnode-queryselectorall

Closes #851.
@brunoabinader
Added Node's query_selector_all helper function
b0e8f7c
@brunoabinader
Implement support for ParentNode's querySelectorAll
95dcab6
@brunoabinader
Added ParentNode's querySelectorAll content tests
Loading status checks…
8c017d8
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jun 10, 2014

Critic review: https://critic.hoppipolla.co.uk/r/1786

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 8c017d8 Jun 11, 2014

saw approval from Ms2ger
at https://github.com/brunoabinader/servo/commit/8c017d8830a31434365bf10694487ed4ab8748da

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jun 11, 2014

merging brunoabinader/servo/document-queryselectorall = 8c017d8 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jun 11, 2014

brunoabinader/servo/document-queryselectorall = 8c017d8 merged ok, testing candidate = baa97fe

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jun 11, 2014

all tests pass:
success: http://servo-buildbot.pub.build.mozilla.org/builders/linux/builds/1594
success: http://servo-buildbot.pub.build.mozilla.org/builders/mac/builds/1550

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jun 11, 2014

fast-forwarding master to auto = baa97fe
bors-servo pushed a commit that referenced this pull request Jun 11, 2014
bors-servo
auto merge of #2632 : brunoabinader/servo/document-queryselectorall, …
baa97fe 
…r=Ms2ger

Spec:
http://dom.spec.whatwg.org/#dom-parentnode-queryselectorall

Closes #851.
@bors-servo bors-servo merged commit 8c017d8 into servo:master Jun 11, 2014
1 check passed
1 check passed
default all tests passed
@brunoabinader brunoabinader deleted the brunoabinader:document-queryselectorall branch Jun 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Implement document.querySelectorAll and document.querySelector
3 participants
@brunoabinader @hoppipolla-critic-bot @bors-servo
You can’t perform that action at this time.