Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more Cargo.toml cleanups #26320

Merged
merged 1 commit into from Apr 26, 2020
Merged

Some more Cargo.toml cleanups #26320

merged 1 commit into from Apr 26, 2020

Conversation

@atouchet
Copy link
Contributor

atouchet commented Apr 26, 2020

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___
@atouchet
More Cargo.toml updates
Loading status checks…
0da9ba5
@highfive
Copy link

highfive commented Apr 26, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/Cargo.toml
  • @KiChjang: components/net/Cargo.toml, components/script/Cargo.toml
@highfive
Copy link

highfive commented Apr 26, 2020

warning Warning warning

  • These commits modify net and script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Apr 26, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2020

📌 Commit 0da9ba5 has been approved by jdm
@highfive highfive assigned jdm and unassigned ferjm Apr 26, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2020

⌛ Testing commit 0da9ba5 with merge 4a3f664...
bors-servo added a commit that referenced this pull request Apr 26, 2020
@bors-servo
Auto merge of #26320 - atouchet:cargo, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4a3f664 
Some more Cargo.toml cleanups

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2020

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Apr 26, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2020

⌛ Testing commit 0da9ba5 with merge fdc3a3f...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing fdc3a3f to master...
@bors-servo bors-servo merged commit fdc3a3f into servo:master Apr 26, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Apr 26, 2020
Closed
@atouchet atouchet deleted the atouchet:cargo branch Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@atouchet @highfive @jdm @bors-servo @CYBAI @ferjm
You can’t perform that action at this time.