Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove devtools experience when navigating #26325
Conversation
highfive
commented
Apr 26, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
Apr 26, 2020
|
|
jdm
changed the title
Break the association between pipelines and browsing context actors. Now there is one browsing context actor per actual browsing context, and individual actors keep track of known pipelines as necessary. There is also one console/performance/timeline/inspector/etc. actor per browsing context. This also centralizes more information in the browsing context actor. Rather than duplicating state for the active pipeline in actors that need to use it, each actor now remembers the name of its associated browsing context actor and obtains that state whenever it's necessary.
|
r? @asajeffrey (due to highfive's severe but fair random selection) |
|
I would be happy to review this if @asajeffrey has other things to do, I started casually looking at this yesterday already... In any case, I do have one suggestion: instead of using the (note that worker threads have their own pipeline namespace, which would be necessary to create such an id, since #23934) I think that would make it easier to use in the context of the Service worker as well, since unlike the dedicated worker that one cannot easily be tied to a BC. |
|
I would rather file that as a possible improvement, since service worker support is only hypothetical right now. |
|
Sounds good, then as far as I can tell it looks good to me. |
| }; | ||
| self.streams.borrow_mut().push(stream.try_clone().unwrap()); | ||
| stream.write_json_packet(&msg); | ||
| // FIXME: fix messages to not requir forging a pipeline for worker messages |
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r=gterzian |
|
|
Improve devtools experience when navigating The primary motivation for this work was to fix #15425, and these changes make it possible to use the devtools to meaningfully inspect multiple pages when navigating between them. Navigating through session history is not yet supported. These changes also include improvements to the dedicated worker support, which broke at some point. We now can observe console messages in workers.
|
|
|
@bors-servo r=gterzian |
|
|
Improve devtools experience when navigating The primary motivation for this work was to fix #15425, and these changes make it possible to use the devtools to meaningfully inspect multiple pages when navigating between them. Navigating through session history is not yet supported. These changes also include improvements to the dedicated worker support, which broke at some point. We now can observe console messages in workers.
|
|
|
@bors-servo retry |
|
|
jdm commentedApr 26, 2020
The primary motivation for this work was to fix #15425, and these changes make it possible to use the devtools to meaningfully inspect multiple pages when navigating between them. Navigating through session history is not yet supported.
These changes also include improvements to the dedicated worker support, which broke at some point. We now can observe console messages in workers.