Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for WebGL2 MIN_PROGRAM_TEXEL_OFFSET #26336
Merged
Conversation
highfive
commented
Apr 28, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
Apr 28, 2020
|
|
mmatyas
force-pushed the
szeged:mmatyas__webgl_fns_getparam4
branch
from
73379d9
to
8eb4f91
|
|
Adds support for the following new WebGL2 GetParameter values: - `PACK_ROW_LENGTH` - `PACK_SKIP_PIXELS` - `PACK_SKIP_ROWS` - `RASTERIZER_DISCARD` - `UNPACK_IMAGE_HEIGHT` - `UNPACK_ROW_LENGTH` - `UNPACK_SKIP_IMAGES` - `UNPACK_SKIP_PIXELS` - `UNPACK_SKIP_ROWS` See: https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7.2
Improves the support of the WebGL2 `MIN_PROGRAM_TEXEL_OFFSET` property (ie. stores it as a signed integer) and adds support for querying it using GetParameter. See: https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7.2
mmatyas
force-pushed the
szeged:mmatyas__webgl_fns_getparam4
branch
from
8eb4f91
to
1431a38
|
Rebased to #26333. |
|
@bors-servo r+ |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mmatyas commentedApr 28, 2020
Improves the support of the WebGL2
MIN_PROGRAM_TEXEL_OFFSETproperty (ie. stores it as a signed integer) and adds support for querying it using GetParameter.See: https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7.2
cc @jdm @zakorgy
Depends on #26333 because they touch the same test files.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors