Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove devtools output for console APIs #26346
Merged
Conversation
highfive
commented
Apr 28, 2020
|
Heads up! This PR modifies the following files:
|
|
@bors-servo try=wpt |
highfive
commented
Apr 28, 2020
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 28, 2020
Console caller These changes use the new API from servo/rust-mozjs#508 to report meaningful filenames and line numbers for APIs that trigger devtools output. They also cause error messages originating from uncompiled event handlers to report a more relevant filename; this differs from Gecko's behaviour, but provides a more useful debugging experience in my opinion. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #9604 and #26344. - [x] These changes do not require tests because devtools aren't tested.
|
@bors-servo r=SimonSapin |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 29, 2020
Improve devtools output for console APIs These changes use the new API from servo/rust-mozjs#508 to report meaningful filenames and line numbers for APIs that trigger devtools output. They also cause error messages originating from uncompiled event handlers to report a more relevant filename; this differs from Gecko's behaviour, but provides a more useful debugging experience in my opinion. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #9604 and fix #26344. - [x] These changes do not require tests because devtools aren't tested.
|
|
|
@bors-servo r=Manishearth |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 29, 2020
Improve devtools output for console APIs These changes use the new API from servo/rust-mozjs#508 to report meaningful filenames and line numbers for APIs that trigger devtools output. They also cause error messages originating from uncompiled event handlers to report a more relevant filename; this differs from Gecko's behaviour, but provides a more useful debugging experience in my opinion. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #9604 and fix #26344. - [x] These changes do not require tests because devtools aren't tested.
|
|
|
@bors-servo retry |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedApr 28, 2020
•
edited by atouchet
These changes use the new API from servo/rust-mozjs#508 to report meaningful filenames and line numbers for APIs that trigger devtools output. They also cause error messages originating from uncompiled event handlers to report a more relevant filename; this differs from Gecko's behaviour, but provides a more useful debugging experience in my opinion.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors