Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for some more WebGL2 limit parameters #26354

Merged
merged 1 commit into from Apr 30, 2020

Conversation

@jdm
Copy link
Member

jdm commented Apr 29, 2020

Adds support for the following new WebGL2 GetParameter values:

  • MAX_ELEMENT_INDEX
  • MAX_ELEMENTS_INDICES
  • MAX_ELEMENTS_VERTICES
  • MAX_FRAGMENT_INPUT_COMPONENTS
  • MAX_SAMPLES
  • MAX_SERVER_WAIT_TIMEOUT
  • MAX_TEXTURE_LOD_BIAS
  • MAX_VARYING_COMPONENTS
  • MAX_VERTEX_OUTPUT_COMPONENTS

See: https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7.2

@highfive
Copy link

highfive commented Apr 29, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webgl2renderingcontext.rs
  • @KiChjang: components/script/dom/webgl2renderingcontext.rs
@highfive
Copy link

highfive commented Apr 29, 2020

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@jdm
Copy link
Member Author

jdm commented Apr 29, 2020

@bors-servo try=wpt-mac

@bors-servo
Copy link
Contributor

bors-servo commented Apr 29, 2020

Trying commit 81c971e with merge cc5363b...

bors-servo added a commit that referenced this pull request Apr 29, 2020
Add support for some more WebGL2 limit parameters

Adds support for the following new WebGL2 GetParameter values:

- `MAX_ELEMENT_INDEX`
- `MAX_ELEMENTS_INDICES`
- `MAX_ELEMENTS_VERTICES`
- `MAX_FRAGMENT_INPUT_COMPONENTS`
- `MAX_SAMPLES`
- `MAX_SERVER_WAIT_TIMEOUT`
- `MAX_TEXTURE_LOD_BIAS`
- `MAX_VARYING_COMPONENTS`
- `MAX_VERTEX_OUTPUT_COMPONENTS`

See: https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7.2
@jdm jdm mentioned this pull request Apr 29, 2020
3 of 3 tasks complete
@bors-servo
Copy link
Contributor

bors-servo commented Apr 29, 2020

💔 Test failed - status-taskcluster

@jdm jdm force-pushed the jdm:mmatyas__webgl_fns_getparam2 branch from 81c971e to 0064cad Apr 29, 2020
@jdm
Copy link
Member Author

jdm commented Apr 29, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Apr 29, 2020

📌 Commit 0064cad has been approved by jdm

@highfive highfive assigned jdm and unassigned SimonSapin Apr 29, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Apr 29, 2020

Testing commit 0064cad with merge 783ab5e...

bors-servo added a commit that referenced this pull request Apr 29, 2020
Add support for some more WebGL2 limit parameters

Adds support for the following new WebGL2 GetParameter values:

- `MAX_ELEMENT_INDEX`
- `MAX_ELEMENTS_INDICES`
- `MAX_ELEMENTS_VERTICES`
- `MAX_FRAGMENT_INPUT_COMPONENTS`
- `MAX_SAMPLES`
- `MAX_SERVER_WAIT_TIMEOUT`
- `MAX_TEXTURE_LOD_BIAS`
- `MAX_VARYING_COMPONENTS`
- `MAX_VERTEX_OUTPUT_COMPONENTS`

See: https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7.2
@bors-servo
Copy link
Contributor

bors-servo commented Apr 29, 2020

💔 Test failed - status-taskcluster

Adds support for the following new WebGL2 GetParameter values:

- `MAX_ELEMENT_INDEX`
- `MAX_ELEMENTS_INDICES`
- `MAX_ELEMENTS_VERTICES`
- `MAX_FRAGMENT_INPUT_COMPONENTS`
- `MAX_SAMPLES`
- `MAX_SERVER_WAIT_TIMEOUT`
- `MAX_TEXTURE_LOD_BIAS`
- `MAX_VARYING_COMPONENTS`
- `MAX_VERTEX_OUTPUT_COMPONENTS`

See: https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7.2
@jdm jdm force-pushed the jdm:mmatyas__webgl_fns_getparam2 branch from 0064cad to c5f0bff Apr 29, 2020
@jdm
Copy link
Member Author

jdm commented Apr 29, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Apr 29, 2020

📌 Commit c5f0bff has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Apr 29, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member Author

jdm commented Apr 29, 2020

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Apr 29, 2020

Testing commit c5f0bff with merge 0dfb85c...

bors-servo added a commit that referenced this pull request Apr 29, 2020
Add support for some more WebGL2 limit parameters

Adds support for the following new WebGL2 GetParameter values:

- `MAX_ELEMENT_INDEX`
- `MAX_ELEMENTS_INDICES`
- `MAX_ELEMENTS_VERTICES`
- `MAX_FRAGMENT_INPUT_COMPONENTS`
- `MAX_SAMPLES`
- `MAX_SERVER_WAIT_TIMEOUT`
- `MAX_TEXTURE_LOD_BIAS`
- `MAX_VARYING_COMPONENTS`
- `MAX_VERTEX_OUTPUT_COMPONENTS`

See: https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7.2
@bors-servo
Copy link
Contributor

bors-servo commented Apr 30, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member Author

jdm commented Apr 30, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Apr 30, 2020

Testing commit c5f0bff with merge d1eb722...

bors-servo added a commit that referenced this pull request Apr 30, 2020
Add support for some more WebGL2 limit parameters

Adds support for the following new WebGL2 GetParameter values:

- `MAX_ELEMENT_INDEX`
- `MAX_ELEMENTS_INDICES`
- `MAX_ELEMENTS_VERTICES`
- `MAX_FRAGMENT_INPUT_COMPONENTS`
- `MAX_SAMPLES`
- `MAX_SERVER_WAIT_TIMEOUT`
- `MAX_TEXTURE_LOD_BIAS`
- `MAX_VARYING_COMPONENTS`
- `MAX_VERTEX_OUTPUT_COMPONENTS`

See: https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7.2
@bors-servo
Copy link
Contributor

bors-servo commented Apr 30, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member Author

jdm commented Apr 30, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Apr 30, 2020

Testing commit c5f0bff with merge 3bedd44...

@bors-servo
Copy link
Contributor

bors-servo commented Apr 30, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 3bedd44 to master...

@bors-servo bors-servo merged commit 3bedd44 into servo:master Apr 30, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.