Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have animations more closely match the HTML spec #26407

Merged
merged 2 commits into from May 6, 2020

Commits on May 5, 2020

  1. Use a restyle for animation ticks

    This change corrects synchronization issues with animations, by
    reworking the animation processing model to do a quick restyle and
    incremental layout when ticking animations.
    
    While this change adds overhead to animation ticks, the idea is that
    this will be the fallback when synchronous behavior is required to
    fulfill specification requirements. In the optimistic case, many
    animations could be updated and applied off-the-main-thread and then
    resynchronized when style information is queried by script.
    
    Fixes #13865.
    mrobinson committed May 5, 2020
  2. Start having animations conform to the HTML spec

    This is a small step toward fixing #19242. The main idea is that the
    clock for animations should advance as the event loop ticks. We
    accomplish this by moving the clock from layout and naming it the
    "animation timeline" which is the spec language. This should fix
    flakiness with animations and transitions tests where a reflow could
    move animations forward while script was running.
    
    This change also starts to break out transition and animation events
    into their own data structure, because it's quite likely that the next
    step in fixing #19242 is to no longer send these events through a
    channel.
    mrobinson committed May 5, 2020
You can’t perform that action at this time.