Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update window.open() to return fallible result #26410

Merged
merged 1 commit into from May 5, 2020
Merged

Update window.open() to return fallible result #26410

merged 1 commit into from May 5, 2020

Conversation

@utsavoza
Copy link
Contributor

utsavoza commented May 4, 2020 •
edited

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes partially fix #26287
  • There are tests for these changes
@utsavoza
Update window.open() to return fallible result
Loading status checks…
86a5cf7
@highfive
Copy link

highfive commented May 4, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/document.rs, components/script/dom/webidls/Document.webidl, components/script/dom/windowproxy.rs, components/script/dom/window.rs, components/script/dom/webidls/Window.webidl
  • @KiChjang: components/script/dom/document.rs, components/script/dom/webidls/Document.webidl, components/script/dom/windowproxy.rs, components/script/dom/window.rs, components/script/dom/webidls/Window.webidl
@ferjm
Copy link
Member

ferjm commented May 5, 2020

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented May 5, 2020

⌛ Trying commit 86a5cf7 with merge 61909d4...
bors-servo added a commit that referenced this pull request May 5, 2020
@bors-servo
Auto merge of #26410 - utsavoza:ugo/issue-26287/04-05-2020, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
61909d4 
Update window.open() to return fallible result

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes partially fix #26287
- [x] There are tests for these changes
@bors-servo
Copy link
Contributor

bors-servo commented May 5, 2020

☀️ Test successful - status-taskcluster
State: approved= try=True
@ferjm
Copy link
Member

ferjm commented May 5, 2020

Thanks!

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 5, 2020

📌 Commit 86a5cf7 has been approved by ferjm
@bors-servo
Copy link
Contributor

bors-servo commented May 5, 2020

⌛ Testing commit 86a5cf7 with merge 5e44327...
@bors-servo
Copy link
Contributor

bors-servo commented May 5, 2020

☀️ Test successful - status-taskcluster
Approved by: ferjm
Pushing 5e44327 to master...
@bors-servo bors-servo merged commit 5e44327 into servo:master May 5, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@utsavoza utsavoza mentioned this pull request May 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ferjm ferjm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Investigate failure of URL parsing tests
4 participants
@utsavoza @highfive @ferjm @bors-servo
You can’t perform that action at this time.