Correctly paint the CSS canvas’ background #26414

SimonSapin · 2020-05-04T16:21:02Z

https://drafts.csswg.org/css-backgrounds/#special-backgrounds

Fixes #25559
Closes #26121, as it is an alternative.
Fixes #26444.

highfive · 2020-05-04T16:21:09Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/node.rs
@jgraham: tests/wpt/reftests-report/gen.py, tests/wpt/reftests-report/prism.css, tests/wpt/reftests-report/prism.js
@KiChjang: components/script/dom/node.rs
@emilio: components/style/values/specified/box.rs

SimonSapin · 2020-05-04T16:29:29Z

At the moment this PR has the same test expectation changes as #26121. It passes a couple more tests, but has some remaining regressions on my machine.

@bors-servo try=wpt-2020

These two tests dynamically set display: none to the root element. They hang without output, I haven’t investigated them yet.

▶ TIMEOUT [expected PASS] /css/css-backgrounds/background-color-root-propagation-002.html
▶ TIMEOUT [expected PASS] /css/css-backgrounds/background-color-body-propagation-006.html

A transform on the root element is not applied to the positioning area of the canvas’s background images. @mrobinson Would calling build_reference_frame_if_necessary on the root StackingContext be appropriate here?

Also, the painting area is a rectangle in the top-level (un-transformed) coordinate space, but the display item’s bounds rect is in local (transformed) coordinates. So we may need to take the axis-aligned bounding box of the inverse-transformed rect.
```
▶ FAIL [expected PASS] /css/css-transforms/transform-translate-background-002.html
▶ FAIL [expected PASS] /css/css-transforms/transform-translate-background-001.html
```

bors-servo · 2020-05-04T16:29:35Z

⌛ Trying commit 70f2ead with merge 5454e9b...


        Auto merge of #26414 - servo:canvas-background2, r=<try>

Correctly paint the CSS canvas’ background https://drafts.csswg.org/css-backgrounds/#special-backgrounds Fixes #25559 Closes #26121, as it is an alternative.

bors-servo · 2020-05-04T17:11:15Z

💔 Test failed - status-taskcluster

mrobinson · 2020-05-05T13:39:22Z

A transform on the root element is not applied to the positioning area of the canvas’s background images. @mrobinson Would calling build_reference_frame_if_necessary on the root StackingContext be appropriate here?

This depends: Is the other content on the page transformed? If it is, the correct solution would likely be to assign the background display item the correct reference frame as its spatial node. If the rest of the page content is not transformed (but should be), then I think appropriate thing would be to create a new reference frame at the the top level.

bors-servo · 2020-05-06T09:15:27Z

☔ The latest upstream changes (presumably #26407) made this pull request unmergeable. Please resolve the merge conflicts.

SimonSapin · 2020-05-07T11:41:23Z

@bors-servo try=wpt-2020

bors-servo · 2020-05-07T11:41:29Z

⌛ Trying commit 0a39c6a with merge ce9c20f...


        Auto merge of #26414 - servo:canvas-background2, r=<try>

Correctly paint the CSS canvas’ background https://drafts.csswg.org/css-backgrounds/#special-backgrounds Fixes #25559 Closes #26121, as it is an alternative. Fixes #26444.

components/layout_2020/display_list/stacking_context.rs

bors-servo · 2020-05-11T20:17:17Z

☔ The latest upstream changes (presumably #26477) made this pull request unmergeable. Please resolve the merge conflicts.

jdm · 2020-05-11T20:20:27Z

@mrobinson Do you want to review Simon's change here?

components/layout_2020/display_list/stacking_context.rs

components/layout_2020/flow/root.rs


        Rename BoxTreeRoot/FragmentTreeRoot to BoxTree/FragmentTree


        Rewrite handling of pointers to boxes in the DOM tree


        Separate computing a WR reference frame from adding it to the display…

… list


        Correctly paint the CSS canvas’ background

https://drafts.csswg.org/css-backgrounds/#special-backgrounds Fixes #25559 Closes #26121, as it is an alternative.


        Fix incorrect sign background-image rectangle computation


        Update WPT expectations

SimonSapin · 2020-05-15T11:43:06Z

However in doing so I seem to have broken transforms (many WPT failures) so that still needs investigating.

Alright, you gave me the correct lead on Matrix to fix this bug. This uncovered another pre-existing bug, for which I added a separate commit. And I also introduced another bug in passing, now fixed as well. I think this should be in pretty good shape now.

@bors-servo try=wpt-2020

bors-servo · 2020-05-15T11:43:11Z

⌛ Trying commit a024ecc with merge 13011ee...


        Auto merge of #26414 - servo:canvas-background2, r=<try>

Correctly paint the CSS canvas’ background https://drafts.csswg.org/css-backgrounds/#special-backgrounds Fixes #25559 Closes #26121, as it is an alternative. Fixes #26444.

bors-servo · 2020-05-15T12:23:15Z

☀️ Test successful - status-taskcluster
State: approved= try=True

mrobinson

Thanks! These changes look good.

SimonSapin · 2020-05-15T13:49:51Z

@bors-servo r=mrobinson

bors-servo · 2020-05-15T13:49:52Z

📌 Commit a024ecc has been approved by mrobinson

bors-servo · 2020-05-15T14:20:26Z

⌛ Testing commit a024ecc with merge 7d7e987...

bors-servo · 2020-05-15T15:23:26Z

☀️ Test successful - status-taskcluster
Approved by: mrobinson
Pushing 7d7e987 to master...


        Auto merge of #26565 - ferjm:layout_2020_viewer_fix, r=SimonSapin

Adapt layout 2020 viewer to new BoxTree and FragmentTree structs - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors #26414 introduced some changes to how we represent the box and fragment trees, so we need to adapt the layout viewer to support them.

SimonSapin added the A-layout/2020 label May 4, 2020

highfive assigned ferjm May 4, 2020

highfive added the S-awaiting-review label May 4, 2020

atouchet added this to Architecture in Layout 2020 May 4, 2020

SimonSapin mentioned this pull request May 4, 2020

layout_2020: Properly handle HTML element background #26121

Closed

4 of 5 tasks complete

highfive added the S-tests-failed label May 4, 2020

jdm mentioned this pull request May 6, 2020

Panic on wikipedia page #26444

Closed

highfive added the S-needs-rebase label May 6, 2020

SimonSapin force-pushed the canvas-background2 branch from 70f2ead to ed27ba1 May 7, 2020

highfive removed the S-tests-failed label May 7, 2020

SimonSapin force-pushed the canvas-background2 branch from ed27ba1 to 0a39c6a May 7, 2020

SimonSapin force-pushed the canvas-background2 branch from 0a39c6a to 4bddac9 May 7, 2020

SimonSapin marked this pull request as ready for review May 7, 2020

SimonSapin reviewed May 7, 2020

View changes

components/layout_2020/display_list/stacking_context.rs Outdated Show resolved Hide resolved

mrobinson reviewed May 12, 2020

View changes

components/layout_2020/display_list/stacking_context.rs Outdated Show resolved Hide resolved

mrobinson reviewed May 12, 2020

View changes

components/layout_2020/flow/root.rs Outdated Show resolved Hide resolved

mrobinson reviewed May 12, 2020

View changes

components/layout_2020/flow/root.rs Outdated Show resolved Hide resolved

mrobinson reviewed May 12, 2020

View changes

components/layout_2020/flow/root.rs Outdated Show resolved Hide resolved

SimonSapin and others added 6 commits Apr 17, 2020

Rename BoxTreeRoot/FragmentTreeRoot to BoxTree/FragmentTree

c43ab0c

Rewrite handling of pointers to boxes in the DOM tree

3e86233

Separate computing a WR reference frame from adding it to the display…

c7acfc3

… list

Correctly paint the CSS canvas’ background

1f6efbf

https://drafts.csswg.org/css-backgrounds/#special-backgrounds Fixes #25559 Closes #26121, as it is an alternative.

Fix incorrect sign background-image rectangle computation

f53ac95

Update WPT expectations

Loading status checks…

a024ecc

SimonSapin force-pushed the canvas-background2 branch from 761318a to a024ecc May 15, 2020

mrobinson approved these changes May 15, 2020

View changes

highfive assigned mrobinson and unassigned ferjm May 15, 2020

highfive added S-awaiting-merge and removed S-awaiting-review S-needs-rebase labels May 15, 2020

bors-servo merged commit 7d7e987 into master May 15, 2020
2 checks passed

2 checks passed

Community-TC (pull_request) TaskGroup: success
Details

homu Test successful
Details

Layout 2020 automation moved this from Architecture to Merged / resolved May 15, 2020

bors-servo deleted the canvas-background2 branch May 15, 2020

highfive removed the S-awaiting-merge label May 15, 2020

This was referenced May 15, 2020

Implement concept of dirty root #26484

Merged

layout_2020: Implement support for backface-visibility #26537

Merged

ferjm mentioned this pull request May 19, 2020

Adapt layout 2020 viewer to new BoxTree and FragmentTree structs #26565

Merged

2 of 2 tasks complete

servo / servo

Correctly paint the CSS canvas’ background #26414

Correctly paint the CSS canvas’ background #26414

SimonSapin commented May 4, 2020 •

edited by jdm

highfive commented May 4, 2020

SimonSapin commented May 4, 2020

bors-servo commented May 4, 2020

bors-servo commented May 4, 2020

mrobinson commented May 5, 2020

bors-servo commented May 6, 2020

SimonSapin commented May 7, 2020

bors-servo commented May 7, 2020

bors-servo commented May 11, 2020

jdm commented May 11, 2020

SimonSapin commented May 15, 2020

bors-servo commented May 15, 2020

bors-servo commented May 15, 2020

mrobinson left a comment

SimonSapin commented May 15, 2020

bors-servo commented May 15, 2020

bors-servo commented May 15, 2020

bors-servo commented May 15, 2020

servo / servo

Join GitHub today

Correctly paint the CSS canvas’ background #26414

Correctly paint the CSS canvas’ background #26414

Conversation

SimonSapin commented May 4, 2020 • edited by jdm

highfive commented May 4, 2020

SimonSapin commented May 4, 2020

bors-servo commented May 4, 2020

bors-servo commented May 4, 2020

mrobinson commented May 5, 2020

bors-servo commented May 6, 2020

SimonSapin commented May 7, 2020

bors-servo commented May 7, 2020

bors-servo commented May 11, 2020

jdm commented May 11, 2020

SimonSapin commented May 15, 2020

bors-servo commented May 15, 2020

bors-servo commented May 15, 2020

mrobinson left a comment

SimonSapin commented May 15, 2020

bors-servo commented May 15, 2020

bors-servo commented May 15, 2020

bors-servo commented May 15, 2020

SimonSapin commented May 4, 2020 •

edited by jdm