Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow BabylonJS playground to load #26434

Merged
merged 2 commits into from May 13, 2020
Merged

Allow BabylonJS playground to load #26434

merged 2 commits into from May 13, 2020

Conversation

@jdm
Copy link
Member

jdm commented May 5, 2020 •
edited

These changes fix the JS errors that currently appear when loading the page. You can't use the editor, but the webgl canvas works just fine.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #26428 and fix #25478
  • There are tests for these changes
@highfive
Copy link

highfive commented May 5, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/document.rs, components/script/dom/eventtarget.rs, components/script/dom/webidls/Document.webidl, components/script/dom/event.rs, components/script/dom/window.rs and 1 more
  • @KiChjang: components/script/dom/document.rs, components/script/dom/eventtarget.rs, components/script/dom/webidls/Document.webidl, components/script/dom/event.rs, components/script/dom/window.rs and 1 more
@highfive
Copy link

highfive commented May 5, 2020

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member Author

jdm commented May 5, 2020

@bors-servo try=wpt
bors-servo added a commit that referenced this pull request May 5, 2020
@bors-servo
Auto merge of #26434 - jdm:playground, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5bcdf9e 
Allow BabylonJS playground to load

These changes fix the JS errors that currently appear when loading the page. You can't use the editor, but the webgl canvas works just fine.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26428
- [x] There are tests for these changes
@bors-servo
Copy link
Contributor

bors-servo commented May 5, 2020

⌛ Trying commit 40e1f07 with merge 5bcdf9e...
@bors-servo
Copy link
Contributor

bors-servo commented May 5, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented May 5, 2020 

  ▶ Unexpected subtest result in /dom/events/event-global.html:
  └ PASS [expected FAIL] window.event is set to the current event during dispatch
  ▶ Unexpected subtest result in /dom/events/event-global.html:
  └ PASS [expected FAIL] window.event is set to the current event, which is the event passed to dispatch
  ▶ Unexpected subtest result in /html/dom/idlharness.https.html?include=(Document|Window):
  └ PASS [expected FAIL] Document interface: operation queryCommandSupported(DOMString)
  ▶ Unexpected subtest result in /html/dom/idlharness.https.html?include=(Document|Window):
  └ PASS [expected FAIL] Document interface: iframe.contentDocument must inherit property "queryCommandSupported(DOMString)" with the proper type
  ▶ Unexpected subtest result in /html/dom/idlharness.https.html?include=(Document|Window):
  └ PASS [expected FAIL] Document interface: calling queryCommandSupported(DOMString) on iframe.contentDocument with too few arguments must throw TypeError
  ▶ Unexpected subtest result in /html/dom/idlharness.https.html?include=(Document|Window):
  └ PASS [expected FAIL] Document interface: new Document() must inherit property "queryCommandSupported(DOMString)" with the proper type
  ▶ Unexpected subtest result in /html/dom/idlharness.https.html?include=(Document|Window):
  └ PASS [expected FAIL] Document interface: calling queryCommandSupported(DOMString) on new Document() with too few arguments must throw TypeError
  ▶ Unexpected subtest result in /html/dom/idlharness.https.html?include=(Document|Window):
  └ PASS [expected FAIL] Document interface: documentWithHandlers must inherit property "queryCommandSupported(DOMString)" with the proper type
  ▶ Unexpected subtest result in /html/dom/idlharness.https.html?include=(Document|Window):
  └ PASS [expected FAIL] Document interface: calling queryCommandSupported(DOMString) on documentWithHandlers with too few arguments must throw TypeError
  ▶ Unexpected subtest result in /dom/idlharness.window.html?exclude=Node:
  └ PASS [expected FAIL] Window interface: attribute event
jdm added 2 commits May 5, 2020
@jdm
dom: Implement stub queryCommandSupported.
19f4be3
@jdm
dom: Implement current window event.
Loading status checks…
097a846
@jdm jdm force-pushed the jdm:playground branch from 40e1f07 to 097a846 May 13, 2020
@jdm
Copy link
Member Author

jdm commented May 13, 2020

r? @Manishearth
@highfive highfive assigned Manishearth and unassigned SimonSapin May 13, 2020
@Manishearth
Manishearth approved these changes May 13, 2020
View changes
Copy link
Member

Manishearth left a comment

r=me either way
components/script/dom/event.rs
let global = listener.associated_global();

// Step 2.7-2.8
let current_event = if let Some(window) = global.downcast::<Window>() {

This comment has been minimized.

Sign in to view
Copy link
@Manishearth

Manishearth May 13, 2020

Member

i would perhaps call this last_event or something?

This comment has been minimized.

Sign in to view
Copy link
@jdm

jdm May 13, 2020

Author Member

I'm going with the name from the spec.
@jdm
Copy link
Member Author

jdm commented May 13, 2020

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented May 13, 2020

📌 Commit 097a846 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented May 13, 2020

⌛ Testing commit 097a846 with merge 52d9fb5...
@bors-servo
Copy link
Contributor

bors-servo commented May 13, 2020

☀️ Test successful - status-taskcluster
Approved by: Manishearth
Pushing 52d9fb5 to master...
@bors-servo bors-servo merged commit 52d9fb5 into servo:master May 13, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth

Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Support the babylon playground
Implement window "current event"
5 participants
@jdm @highfive @bors-servo @Manishearth @SimonSapin
You can’t perform that action at this time.