Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGeneralize the 2020 regression report to show local unexpected failures #26437
Conversation
highfive
commented
May 5, 2020
|
Heads up! This PR modifies the following files:
|
|
r? @jdm |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 5, 2020
Generalize the 2020 regression report to show local unexpected failures Example usage: ``` ./mach test-wpt --release --layout-2020 --log-raw /tmp/servo.log ./tests/wpt/reftests-report/gen.py /tmp/servo.log firefox ./tests/wpt/reftests-report/report.html ``` Produces a report similar https://community-tc.services.mozilla.com/api/index/v1/task/project.servo.layout-2020-regressions-report/artifacts/public/regressions.html, but showing unexpected reftest failures. The CI-generated one shows Layout 2020 failures (expected or not) that succeed in Layout 2013.
|
|
|
| @@ -157,6 +157,9 @@ def __init__(self, name): | |||
|
|
|||
| with_extra = chaining(update_attr, "extra") | |||
|
|
|||
| def with_index_at(self, index_path): | |||
| self.routes.append("index.%s.%s" % (CONFIG.index_prefix, index_path)) | |||
This comment has been minimized.
This comment has been minimized.
|
Indeed, that fixes running @bors-servo r=jdm |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SimonSapin commentedMay 5, 2020
Example usage:
Produces a report similar https://community-tc.services.mozilla.com/api/index/v1/task/project.servo.layout-2020-regressions-report/artifacts/public/regressions.html, but showing unexpected reftest failures. The CI-generated one shows Layout 2020 failures (expected or not) that succeed in Layout 2013.