Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize the 2020 regression report to show local unexpected failures #26437

Merged
merged 2 commits into from May 7, 2020
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Prev

Generate Layout 2020 regression report more than once

  • Loading branch information
SimonSapin committed May 7, 2020
commit f524363667949e3ed300609eb711ee3ddd1a4f6e
@@ -265,7 +265,8 @@ def layout_2020_regressions_report():
)
.with_index_and_artifacts_expire_in(log_artifacts_expire_in)
.with_artifacts("/repo/tests/wpt/reftests-report/report.html")
.find_or_create("layout-2020-regressions-report")
.with_index_at("layout-2020-regressions-report")
.create()
)

def macos_unit():
@@ -157,6 +157,10 @@ def __init__(self, name):

with_extra = chaining(update_attr, "extra")

def with_index_at(self, index_path):
self.routes.append("index.%s.%s" % (CONFIG.index_prefix, index_path))

This comment has been minimized.

@jdm

jdm May 6, 2020

Member

This needs to return self.

return self

def with_treeherder_required(self):
self.treeherder_required = True
return self
@@ -291,7 +295,7 @@ def find_or_create(self, index_path):
if e.status_code != 404: # pragma: no cover
raise
if not CONFIG.index_read_only:
self.routes.append("index.%s.%s" % (CONFIG.index_prefix, index_path))
self.with_index_at(index_path)
task_id = self.create()

SHARED.found_or_created_indexed_tasks[index_path] = task_id
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.