Skip to content

Comments

Fix the webidl for Headers#26442

Merged
bors-servo merged 1 commit intoservo:masterfrom
Eijebong:might-have-failed-going-to-bed
May 30, 2020
Merged

Fix the webidl for Headers#26442
bors-servo merged 1 commit intoservo:masterfrom
Eijebong:might-have-failed-going-to-bed

Conversation

@Eijebong
Copy link
Contributor

@Eijebong Eijebong commented May 6, 2020

Make the HeadersInit type match the spec.

Fixes #26441

@highfive
Copy link

highfive commented May 6, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/request.rs, components/script/dom/webidls/Headers.webidl, components/script/dom/headers.rs, components/script/dom/response.rs
  • @KiChjang: components/script/dom/request.rs, components/script/dom/webidls/Headers.webidl, components/script/dom/headers.rs, components/script/dom/response.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 6, 2020
@Eijebong Eijebong force-pushed the might-have-failed-going-to-bed branch from 40e53fe to b85602e Compare May 6, 2020 15:21
@Eijebong Eijebong changed the title Fix the webdil for Headers Fix the webidl for Headers May 6, 2020
@jdm
Copy link
Member

jdm commented May 25, 2020

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2020

📌 Commit b85602e has been approved by jdm

@highfive highfive assigned jdm and unassigned asajeffrey May 25, 2020
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 25, 2020
@bors-servo
Copy link
Contributor

bors-servo commented May 26, 2020

⌛ Testing commit b85602e with merge 4cce24e...

bors-servo added a commit that referenced this pull request May 26, 2020
@bors-servo
Auto merge of #26442 - Eijebong:might-have-failed-going-to-bed, r=jdm
4cce24e 
Fix the webidl for Headers

Make the HeadersInit type match the spec.

Fixes #26441
@bors-servo
Copy link
Contributor

bors-servo commented May 26, 2020

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels May 26, 2020
@CYBAI
Copy link
Member

CYBAI commented May 26, 2020

seems more pass tests 👀

  ▶ Unexpected subtest result in /fetch/range/general.any.worker.html:
  └ PASS [expected FAIL] Privileged header not allowed for guard type: request-no-cors
  ▶ Unexpected subtest result in /fetch/range/general.any.html:
  └ PASS [expected FAIL] Privileged header not allowed for guard type: request-no-cors

@Eijebong
Fix the webidl for Headers
c4273d8 
Make the HeadersInit type match the spec.

Fixes servo#26441
@Eijebong Eijebong force-pushed the might-have-failed-going-to-bed branch from b85602e to c4273d8 Compare May 30, 2020 10:48
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels May 30, 2020
@Eijebong
Copy link
Contributor Author

Eijebong commented May 30, 2020

There, updated expectations

@jdm
Copy link
Member

jdm commented May 30, 2020

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2020

📌 Commit c4273d8 has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 30, 2020
@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2020

⌛ Testing commit c4273d8 with merge dafcee4...

@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing dafcee4 to master...

@bors-servo bors-servo merged commit dafcee4 into servo:master May 30, 2020
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jdm jdm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HeadersInit doesn't match specification

6 participants

@Eijebong @highfive @jdm @bors-servo @CYBAI @asajeffrey