Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the webidl for Headers #26442

Merged
merged 1 commit into from May 30, 2020
Merged

Fix the webidl for Headers #26442

merged 1 commit into from May 30, 2020

Conversation

@Eijebong
Copy link
Member

Eijebong commented May 6, 2020

Make the HeadersInit type match the spec.

Fixes #26441
@highfive
Copy link

highfive commented May 6, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/request.rs, components/script/dom/webidls/Headers.webidl, components/script/dom/headers.rs, components/script/dom/response.rs
  • @KiChjang: components/script/dom/request.rs, components/script/dom/webidls/Headers.webidl, components/script/dom/headers.rs, components/script/dom/response.rs
@Eijebong Eijebong force-pushed the Eijebong:might-have-failed-going-to-bed branch from 40e53fe to b85602e May 6, 2020
@Eijebong Eijebong changed the title Fix the webdil for Headers Fix the webidl for Headers May 6, 2020
@jdm
Copy link
Member

jdm commented May 25, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2020

📌 Commit b85602e has been approved by jdm
@highfive highfive assigned jdm and unassigned asajeffrey May 25, 2020
@bors-servo
Copy link
Contributor

bors-servo commented May 26, 2020

⌛ Testing commit b85602e with merge 4cce24e...
bors-servo added a commit that referenced this pull request May 26, 2020
@bors-servo
Auto merge of #26442 - Eijebong:might-have-failed-going-to-bed, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4cce24e 
Fix the webidl for Headers

Make the HeadersInit type match the spec.

Fixes #26441
@bors-servo
Copy link
Contributor

bors-servo commented May 26, 2020

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented May 26, 2020

seems more pass tests 👀

  ▶ Unexpected subtest result in /fetch/range/general.any.worker.html:
  └ PASS [expected FAIL] Privileged header not allowed for guard type: request-no-cors
  ▶ Unexpected subtest result in /fetch/range/general.any.html:
  └ PASS [expected FAIL] Privileged header not allowed for guard type: request-no-cors
@Eijebong
Fix the webidl for Headers
Loading status checks…
c4273d8 
Make the HeadersInit type match the spec.

Fixes #26441
@Eijebong Eijebong force-pushed the Eijebong:might-have-failed-going-to-bed branch from b85602e to c4273d8 May 30, 2020
@Eijebong
Copy link
Member Author

Eijebong commented May 30, 2020

There, updated expectations
@jdm
Copy link
Member

jdm commented May 30, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2020

📌 Commit c4273d8 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2020

⌛ Testing commit c4273d8 with merge dafcee4...
@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing dafcee4 to master...
@bors-servo bors-servo merged commit dafcee4 into servo:master May 30, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

HeadersInit doesn't match specification
6 participants
@Eijebong @highfive @jdm @bors-servo @CYBAI @asajeffrey
You can’t perform that action at this time.