Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webxr #26446

Merged
merged 1 commit into from May 7, 2020
Merged

Update webxr #26446

merged 1 commit into from May 7, 2020
+21 −13

Conversation

@Manishearth
Copy link
Member

Manishearth commented May 6, 2020

Brings in hand input
@Manishearth Manishearth requested a review from jdm May 6, 2020
@CYBAI
Copy link
Collaborator

CYBAI commented May 6, 2020 

Checking files for tidiness...
./Cargo.lock:1: duplicate versions for package `libloading`
	The following packages depend on version 0.5.2 from 'crates.io':
	The following packages depend on version 0.6.1 from 'crates.io':
Running the dependency licensing lint...
@Manishearth
Copy link
Member Author

Manishearth commented May 6, 2020

Hmmm. I'm okay with allowing that, but i can also undo the dep bump in the patch (it's a proactive dep bump and not strictly required). We'll have to redo it when we switch back to openxrs master. Thoughts?
@Manishearth
Update webxr
Loading status checks…
bb652a0
@Manishearth Manishearth force-pushed the Manishearth:hands-openxr branch from c5fdcce to bb652a0 May 6, 2020
@asajeffrey
asajeffrey approved these changes May 7, 2020
View changes
Copy link
Member

asajeffrey left a comment

Oh that's annoying re libloading. You can r=me anyway.
@Manishearth
Copy link
Member Author

Manishearth commented May 7, 2020

@bors-servo r=asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented May 7, 2020

📌 Commit bb652a0 has been approved by asajeffrey
@highfive highfive unassigned jdm May 7, 2020
@bors-servo
Copy link
Contributor

bors-servo commented May 7, 2020

⌛ Testing commit bb652a0 with merge 535a00b...
bors-servo added a commit that referenced this pull request May 7, 2020
@bors-servo
Auto merge of #26446 - Manishearth:hands-openxr, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
535a00b 
Update webxr

Brings in hand input
@bors-servo
Copy link
Contributor

bors-servo commented May 7, 2020

💔 Test failed - status-taskcluster
@Manishearth
Copy link
Member Author

Manishearth commented May 7, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 7, 2020

⌛ Testing commit bb652a0 with merge da20f0b...
bors-servo added a commit that referenced this pull request May 7, 2020
@bors-servo
Auto merge of #26446 - Manishearth:hands-openxr, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
da20f0b 
Update webxr

Brings in hand input
@bors-servo
Copy link
Contributor

bors-servo commented May 7, 2020

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented May 7, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 7, 2020

⌛ Testing commit bb652a0 with merge 805258f...
@bors-servo
Copy link
Contributor

bors-servo commented May 7, 2020

☀️ Test successful - status-taskcluster
Approved by: asajeffrey
Pushing 805258f to master...
@bors-servo bors-servo merged commit 805258f into servo:master May 7, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request May 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asajeffrey asajeffrey

@jdm jdm

Assignees

@asajeffrey asajeffrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@Manishearth @CYBAI @bors-servo @asajeffrey @jdm @highfive
You can’t perform that action at this time.