Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync WPT with upstream (06-05-2020) #26451

Merged
merged 2 commits into from May 6, 2020

Conversation

@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented May 6, 2020

Automated downstream sync of changes from upstream as of 06-05-2020.
[no-wpt-sync]
r? @servo-wpt-sync

@servo-wpt-sync
Copy link
Collaborator Author

servo-wpt-sync commented May 6, 2020

@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2020

📌 Commit c5ddf8e has been approved by servo-wpt-sync

bors-servo added a commit that referenced this pull request May 6, 2020
…wpt-sync

Sync WPT with upstream (06-05-2020)

Automated downstream sync of changes from upstream as of 06-05-2020.
[no-wpt-sync]
r? @servo-wpt-sync
@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2020

Testing commit c5ddf8e with merge c20003c...

@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2020

💔 Test failed - status-taskcluster

@CYBAI
Copy link
Collaborator

CYBAI commented May 6, 2020

there are still many running jobs though, is this a new intermittent build failure?

--- stderr
Reticulating splines...
Finished reading 51 moz.build files in 3.94s
Read 0 gyp files in parallel contributing 0.00s to total wall time
Processed into 205 build config descriptors in 0.72s
RecursiveMake backend executed in 2.17s
  141 total backend files; 141 created; 0 updated; 0 unchanged; 0 deleted; 6 -> 32 Makefile
Total wall time: 7.01s; CPU time: 0.85s; Efficiency: 12%; Untracked: 0.19s
In file included from /Users/worker/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/9a6d8fc/mozjs/js/src/gc/StoreBuffer.cpp:7:
In file included from /Users/worker/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/9a6d8fc/mozjs/js/src/gc/StoreBuffer-inl.h:10:
In file included from /Users/worker/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/9a6d8fc/mozjs/js/src/gc/StoreBuffer.h:11:
In file included from /Users/worker/tasks/task_1588755752/repo/target/debug/build/mozjs_sys-4f13869e3bfffe79/out/build/dist/include/mozilla/HashFunctions.h:50:
/Users/worker/tasks/task_1588755752/repo/target/debug/build/mozjs_sys-4f13869e3bfffe79/out/build/dist/include/mozilla/Assertions.h:18:10: fatal error: 'mozilla/Likely.h' file not found
#include "mozilla/Likely.h"
         ^~~~~~~~~~~~~~~~~~
1 error generated.
make[4]: *** [StoreBuffer.o] Error 1
make[3]: *** [js/src/gc/target-objects] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [compile] Error 2
make[1]: *** [default] Error 2
make: *** [all] Error 2
thread 'main' panicked at 'assertion failed: result.success()', /Users/worker/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/9a6d8fc/build.rs:177:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
@jdm
Copy link
Member

jdm commented May 6, 2020

Yes.

@CYBAI
Copy link
Collaborator

CYBAI commented May 6, 2020

@bors-servo retry

  • Filed at #26453 for the new intermittent build failure
  • #25513
@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2020

Testing commit c5ddf8e with merge cd2acfb...

bors-servo added a commit that referenced this pull request May 6, 2020
…wpt-sync

Sync WPT with upstream (06-05-2020)

Automated downstream sync of changes from upstream as of 06-05-2020.
[no-wpt-sync]
r? @servo-wpt-sync
@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented May 6, 2020

Something in these changes is causing the multiprocess tests that run the eventsource/ directory to have a bunch of unexpected results.

@jdm
Copy link
Member

jdm commented May 6, 2020

I see it - wptserve was updated for python3 compatibility, and we run our multiprocess tests with python2 to verify that that codepath keeps working even as we transition most of our tests to running with python3.

@jdm
Copy link
Member

jdm commented May 6, 2020

I lied - we run the eventsource tests twice, once with python2 and once with python3. It's the python3 job that has the failures.

@jdm
Copy link
Member

jdm commented May 6, 2020

Filed web-platform-tests/wpt#23436 and switched us to run the url tests instead of eventsource in the meantime.

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2020

📌 Commit 788f83c has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2020

Testing commit 788f83c with merge 9c88bfb...

@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 9c88bfb to master...

@bors-servo bors-servo merged commit 9c88bfb into servo:master May 6, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.