Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly set the url on the Response object when the response is an opaqueredirect #26455

Merged
merged 1 commit into from May 6, 2020
Merged

Properly set the url on the Response object when the response is an opaqueredirect #26455

merged 1 commit into from May 6, 2020

Conversation

@Eijebong
Copy link
Member

Eijebong commented May 6, 2020

No description provided.

@Eijebong
Properly set the url on the Response object when the response is an o…
Loading status checks…
ec665d9 
…paqueredirect
@highfive
Copy link

highfive commented May 6, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/fetch.rs, components/script/dom/xmlhttprequest.rs, components/script/dom/eventsource.rs, components/script/stylesheet_loader.rs
  • @KiChjang: components/script/fetch.rs, components/script/dom/xmlhttprequest.rs, components/net/image_cache.rs, components/net_traits/lib.rs, components/script/dom/eventsource.rs and 2 more
@jdm
Copy link
Member

jdm commented May 6, 2020

@bors-servo r+
Nice find!
@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2020

📌 Commit ec665d9 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2020

⌛ Testing commit ec665d9 with merge d797066...
bors-servo added a commit that referenced this pull request May 6, 2020
@bors-servo
Auto merge of #26455 - Eijebong:more-redirects, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d797066 
Properly set the url on the Response object when the response is an opaqueredirect
@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented May 6, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2020

⌛ Testing commit ec665d9 with merge 5ee1a48...
@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 5ee1a48 to master...
@bors-servo bors-servo merged commit 5ee1a48 into servo:master May 6, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@Eijebong @highfive @jdm @bors-servo
You can’t perform that action at this time.