Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webxr with secondary view support #26458

Merged
merged 2 commits into from May 13, 2020
Merged

Conversation

@Manishearth
Copy link
Member

Manishearth commented May 7, 2020

Blocked on servo/webxr#171 , untested

@Manishearth Manishearth requested a review from asajeffrey May 7, 2020
@highfive
Copy link

highfive commented May 7, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/xrviewerpose.rs
  • @KiChjang: components/script/dom/xrviewerpose.rs
@highfive
Copy link

highfive commented May 7, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@bors-servo
Copy link
Contributor

bors-servo commented May 7, 2020

The latest upstream changes (presumably #26446) made this pull request unmergeable. Please resolve the merge conflicts.

@Manishearth Manishearth marked this pull request as ready for review May 12, 2020
@Manishearth
Copy link
Member Author

Manishearth commented May 12, 2020

Copy link
Member

asajeffrey left a comment

LGTM, with the [patch] removed from Cargo.toml.

@Manishearth
Copy link
Member Author

Manishearth commented May 12, 2020

yep, that's the plan

bors-servo added a commit to servo/webxr that referenced this pull request May 12, 2020
Support secondary openxr observer view

Servo side: servo/servo#26458

My openxrs branch will  need to be pushed to servo/openxrs before landing: servo/openxrs#1
@Manishearth Manishearth force-pushed the Manishearth:secondary-view branch from 09cad74 to 81497bf May 13, 2020
@Manishearth Manishearth force-pushed the Manishearth:secondary-view branch from 81497bf to da3d2a8 May 13, 2020
@Manishearth
Copy link
Member Author

Manishearth commented May 13, 2020

@bors-servo r=asajeffrey

@bors-servo
Copy link
Contributor

bors-servo commented May 13, 2020

📌 Commit da3d2a8 has been approved by asajeffrey

@bors-servo
Copy link
Contributor

bors-servo commented May 13, 2020

Testing commit da3d2a8 with merge 24de9fd...

bors-servo added a commit that referenced this pull request May 13, 2020
Update webxr with secondary view support

Blocked on servo/webxr#171 , untested
@bors-servo
Copy link
Contributor

bors-servo commented May 13, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented May 13, 2020

@bors-servo
Copy link
Contributor

bors-servo commented May 13, 2020

Testing commit da3d2a8 with merge bdfa6b0...

@bors-servo
Copy link
Contributor

bors-servo commented May 13, 2020

☀️ Test successful - status-taskcluster
Approved by: asajeffrey
Pushing bdfa6b0 to master...

@bors-servo bors-servo merged commit bdfa6b0 into servo:master May 13, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.