Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a TODO from the implementation of getComputedStyle #26481

Merged
merged 1 commit into from May 10, 2020
Merged

Remove a TODO from the implementation of getComputedStyle #26481

merged 1 commit into from May 10, 2020

Conversation

@mrobinson
Copy link
Member

mrobinson commented May 10, 2020

The spec is now clear that disconnected elements shouldn't return a
style.

Closes #6860.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #6860
  • These changes do not require tests because they just update a comment.
@mrobinson
Remove a TODO from the implementation of getComputedStyle
Loading status checks…
4b4ea64 
The spec is now clear that disconnected elements shouldn't return a
style.

Closes #6860.
@mrobinson mrobinson requested a review from emilio May 10, 2020
@highfive
Copy link

highfive commented May 10, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/cssstyledeclaration.rs
  • @KiChjang: components/script/dom/cssstyledeclaration.rs
@highfive
Copy link

highfive commented May 10, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@mrobinson mrobinson mentioned this pull request May 10, 2020
Merged
3 of 3 tasks complete
@jdm
Copy link
Member

jdm commented May 10, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2020

📌 Commit 4b4ea64 has been approved by jdm
@highfive highfive assigned jdm and unassigned nox May 10, 2020
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2020

⌛ Testing commit 4b4ea64 with merge 4d541e8...
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 4d541e8 to master...
@bors-servo bors-servo merged commit 4d541e8 into servo:master May 10, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

getComputedStyle on an element not in a document returns nothing
5 participants
@mrobinson @highfive @jdm @bors-servo @nox
You can’t perform that action at this time.