Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EXT_frag_depth #26483

Merged
merged 1 commit into from May 11, 2020
Merged

Implement EXT_frag_depth #26483

merged 1 commit into from May 11, 2020

Conversation

@splav
Copy link
Contributor

splav commented May 11, 2020

Fixes 26341

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #26341 (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___
@highfive
Copy link

highfive commented May 11, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webgl_extensions/ext/extfragdepth.rs, components/script/dom/webidls/EXTFragDepth.webidl, components/script/dom/webgl_extensions/extensions.rs, components/script/dom/webgl_extensions/ext/mod.rs, components/script/dom/webglshader.rs and 1 more
  • @KiChjang: components/script/dom/webgl_extensions/ext/extfragdepth.rs, components/script/dom/webidls/EXTFragDepth.webidl, components/script/dom/webgl_extensions/extensions.rs, components/script/dom/webgl_extensions/ext/mod.rs, components/script/dom/webglshader.rs and 1 more
@highfive
Copy link

highfive commented May 11, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@splav
Copy link
Contributor Author

splav commented May 11, 2020 •
edited

There are tests for this extension, but they were not failing even before the change. I'm not sure why.
Any clues?
UPD: It's an extension test - it's legal not to support the extension. That's why they passed.

By the way, 3.5 years have passed since my last PR to Servo! Wow...
@splav splav force-pushed the splav:ext_frag_depth branch from 0528804 to 2ff7d46 May 11, 2020
@splav
Implement EXT_frag_depth
Loading status checks…
50e1548
@splav splav force-pushed the splav:ext_frag_depth branch from 2ff7d46 to 50e1548 May 11, 2020
@jdm
Copy link
Member

jdm commented May 11, 2020

r? @jdm
Welcome back! Nice to see you again!
@highfive highfive assigned jdm and unassigned SimonSapin May 11, 2020
@jdm
Copy link
Member

jdm commented May 11, 2020

@bors-servo r+
Great work! Thanks for fixing this.
@bors-servo
Copy link
Contributor

bors-servo commented May 11, 2020

📌 Commit 50e1548 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented May 11, 2020

⌛ Testing commit 50e1548 with merge 252197b...
@bors-servo
Copy link
Contributor

bors-servo commented May 11, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 252197b to master...
@bors-servo bors-servo merged commit 252197b into servo:master May 11, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Implement EXT_frag_depth extension
5 participants
@splav @highfive @jdm @bors-servo @SimonSapin
You can’t perform that action at this time.