Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement concept of dirty root #26484
Conversation
highfive
commented
May 11, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
May 11, 2020
|
I hit the wrong button, I wanted to make a draft PR. Oh well. @bors-servo try |
Implement concept of dirty root
|
|
|
My code is doing bad stuff when the document's children are changed, looking into it. |
|
@bors-servo try=wpt |
[WIP] Implement concept of dirty root
|
|
I must be missing something somewhere. This can only happen if there is an element which doesn't have any data, but I don't see how that can happen through the dirty root, given that the parent without the data should be dirty too. |
|
I guess I can try with 2020 meanwhile. I had to do some fancy stuff in 2013 for incremental restyle, and that stuff is not needed on the 2020 side. @bors-servo try=wpt-2020 |
|
@bors-servo try=wpt-2020 |
[WIP] Implement concept of dirty root
|
|
|
|
[WIP] Implement concept of dirty root
|
|
|
@bors-servo try
|
[WIP] Implement concept of dirty root
|
|
That way we can use borrow_mut_for_layout and borrow_mut.
|
@bors-servo try Everything should be ok now. r? @SimonSapin |
|
Looks good! @bors-servo r+ |
|
|
|
|
nox commentedMay 11, 2020
No description provided.