Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout_2020: Add animations and transitions support #26486

Merged
merged 2 commits into from May 19, 2020
Merged

layout_2020: Add animations and transitions support #26486

merged 2 commits into from May 19, 2020
+3,325 −8,662

Conversation

@mrobinson
Copy link
Member

mrobinson commented May 11, 2020

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #25884
  • There are tests for these changes
@highfive
Copy link

highfive commented May 11, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/Cargo.toml, components/script/script_thread.rs, components/script/animation_timeline.rs, components/script/animations.rs, components/script/dom/bindings/trace.rs and 4 more
  • @cbrewster: components/constellation/constellation.rs
  • @jgraham: tests/wpt/include-layout-2020.ini
  • @KiChjang: components/script_traits/lib.rs, components/script_traits/script_msg.rs, components/script/Cargo.toml, components/script/script_thread.rs, components/script/animation_timeline.rs and 5 more
  • @emilio: components/style/properties/longhands/box.mako.rs, components/style/animation.rs, components/style/properties/shorthands/box.mako.rs, components/layout/context.rs, components/layout/animation.rs and 2 more
@highfive
Copy link

highfive commented May 11, 2020

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@mrobinson
Copy link
Member Author

mrobinson commented May 11, 2020

This change should be ready to land after #26464 and #26477.
@Manishearth Manishearth removed their assignment May 11, 2020
@Manishearth
Copy link
Member

Manishearth commented May 11, 2020

I can review if you want, but i'm assuming you just forgot to ask nox or simon here.
@mrobinson
Copy link
Member Author

mrobinson commented May 11, 2020

Thanks for the offer, @Manishearth. I was thinking I'd post this in case anyone wanted to try it out or had any comments, but then ask for a review when the dependencies landed.
@jdm
Copy link
Member

jdm commented May 11, 2020

I'm a fan of how small 2af288a is.
@bors-servo
Copy link
Contributor

bors-servo commented May 11, 2020

☔ The latest upstream changes (presumably #26477) made this pull request unmergeable. Please resolve the merge conflicts.
@mrobinson mrobinson force-pushed the mrobinson:animation-layout-2020-v2 branch from 627aca4 to ed03a57 May 12, 2020
@mrobinson mrobinson mentioned this pull request May 12, 2020
Closed
20 of 21 tasks complete
@mrobinson mrobinson marked this pull request as ready for review May 14, 2020
@mrobinson
Copy link
Member Author

mrobinson commented May 14, 2020

Okay. I think this is ready to review.
@bors-servo
Copy link
Contributor

bors-servo commented May 15, 2020

☔ The latest upstream changes (presumably #26526) made this pull request unmergeable. Please resolve the merge conflicts.
@mrobinson mrobinson force-pushed the mrobinson:animation-layout-2020-v2 branch from ed03a57 to 558a2de May 15, 2020
@mrobinson mrobinson requested a review from SimonSapin May 15, 2020
@jdm
jdm approved these changes May 15, 2020
View changes
@jdm jdm self-assigned this May 15, 2020
@bors-servo
Copy link
Contributor

bors-servo commented May 16, 2020

☔ The latest upstream changes (presumably #26545) made this pull request unmergeable. Please resolve the merge conflicts.
@mrobinson mrobinson mentioned this pull request May 19, 2020
Merged
3 of 3 tasks complete
mrobinson added 2 commits May 11, 2020
@mrobinson
layout_2020: Add support for transitions and animations
a238597
@mrobinson
Update test expectations
Loading status checks…
acca20d
@mrobinson mrobinson force-pushed the mrobinson:animation-layout-2020-v2 branch from 558a2de to acca20d May 19, 2020
@mrobinson
Copy link
Member Author

mrobinson commented May 19, 2020

@bors-servo try=wpt-2020
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2020

⌛ Trying commit acca20d with merge 2eb746a...
bors-servo added a commit that referenced this pull request May 19, 2020
@bors-servo
Auto merge of #26486 - mrobinson:animation-layout-2020-v2, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2eb746a 
layout_2020: Add animations and transitions support

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25884
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2020

☀️ Test successful - status-taskcluster
State: approved= try=True
@mrobinson
Copy link
Member Author

mrobinson commented May 19, 2020

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2020

📌 Commit acca20d has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2020

⌛ Testing commit acca20d with merge ce3f9c4...
bors-servo added a commit that referenced this pull request May 19, 2020
@bors-servo
Auto merge of #26486 - mrobinson:animation-layout-2020-v2, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ce3f9c4 
layout_2020: Add animations and transitions support

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25884
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2020

💔 Test failed - status-taskcluster
@mrobinson
Copy link
Member Author

mrobinson commented May 19, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2020

⌛ Testing commit acca20d with merge 2e5dc64...
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 2e5dc64 to master...
@bors-servo bors-servo merged commit 2e5dc64 into servo:master May 19, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request May 19, 2020
Merged
3 of 3 tasks complete
@mrobinson mrobinson deleted the mrobinson:animation-layout-2020-v2 branch May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

@SimonSapin SimonSapin

Assignees

@jdm jdm

Labels
A-layout/2020
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Transitions and animations
6 participants
@mrobinson @highfive @Manishearth @jdm @bors-servo @SimonSapin
You can’t perform that action at this time.