Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix an issue with the rooting of animating nodes #26503
Merged
Conversation
highfive
commented
May 13, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
May 13, 2020
|
This is a flaky crash, so there isn't a solid guarantee that this fixes the issue. I tried to be as careful as possible when confirming this though. Before this change the following test:
always resulted in at least one crash. After the change, I could not reproduce the crash at all. |
|
Thanks for investigating and figuring out a way to manually test it! |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedMay 13, 2020
Make sure nodes removed from map of rooted animating nodes are rooted on
the stack before triggering event handlers. We also make sure not to
call
from_untrusted_node_addresson nodes that aren't guaranteed to berooted.
Fixes #26498.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors