Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integrity hash for nightly builds #26510

Merged
merged 2 commits into from May 14, 2020
Merged

Add integrity hash for nightly builds #26510

merged 2 commits into from May 14, 2020

Conversation

@camelid
Copy link
Contributor

camelid commented May 13, 2020 •
edited

Compute a SHA-256 integrity hash for nightly builds on the download.servo.org page.

  • ./mach build -d does not report any errors (it does, but unrelated to the change)
  • ./mach test-tidy does not report any errors
  • These changes fix servo/download.servo.org#14 (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because they're in the infrastructure
@camelid
Add integrity hash for nightly builds
Loading status checks…
f1e37e2
@highfive
Copy link

highfive commented May 13, 2020

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.
@highfive
Copy link

highfive commented May 13, 2020

Heads up! This PR modifies the following files:
@camelid
Copy link
Contributor Author

camelid commented May 13, 2020

Feel free to suggest changes, I'm still unsure about how the infrastructure works!
@Manishearth Manishearth requested a review from jdm May 13, 2020
@jdm
jdm requested changes May 13, 2020
View changes
python/servo/package_commands.py Outdated Show resolved Hide resolved
@jdm jdm assigned jdm and unassigned Manishearth May 13, 2020
@camelid
Only upload latest hash
Loading status checks…
6faccf6
@camelid camelid requested a review from jdm May 13, 2020
@jdm
Copy link
Member

jdm commented May 13, 2020

@bors-servo r+
Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented May 13, 2020

📌 Commit 6faccf6 has been approved by jdm
@camelid
Copy link
Contributor Author

camelid commented May 13, 2020

Thanks! :)
@bors-servo
Copy link
Contributor

bors-servo commented May 13, 2020

⌛ Testing commit 6faccf6 with merge 3a06e18...
bors-servo added a commit that referenced this pull request May 13, 2020
@bors-servo
Auto merge of #26510 - camelid:checksum, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3a06e18 
Add integrity hash for nightly builds

<!-- Please describe your changes on the following line: -->
Compute a SHA-256 integrity hash for nightly builds on the download.servo.org page.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors (it does, but unrelated to the change)
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix servo/download.servo.org#14 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they're in the infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented May 13, 2020

💔 Test failed - status-taskcluster
@camelid
Copy link
Contributor Author

camelid commented May 13, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 13, 2020

@camelid: 🔑 Insufficient privileges: not in try users
@camelid
Copy link
Contributor Author

camelid commented May 13, 2020

@jdm For some reason, one of the tests timed-out. I tried to tell bors to retry it, but apparently I need privileges :). Could you tell bors to retry it?
@jdm
Copy link
Member

jdm commented May 13, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 13, 2020

⌛ Testing commit 6faccf6 with merge e06378f...
bors-servo added a commit that referenced this pull request May 13, 2020
@bors-servo
Auto merge of #26510 - camelid:checksum, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e06378f 
Add integrity hash for nightly builds

<!-- Please describe your changes on the following line: -->
Compute a SHA-256 integrity hash for nightly builds on the download.servo.org page.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors (it does, but unrelated to the change)
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix servo/download.servo.org#14 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they're in the infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented May 14, 2020

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented May 14, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 14, 2020

⌛ Testing commit 6faccf6 with merge 6c506ba...
@bors-servo
Copy link
Contributor

bors-servo commented May 14, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 6c506ba to master...
@bors-servo bors-servo merged commit 6c506ba into servo:master May 14, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@camelid
Copy link
Contributor Author

camelid commented May 14, 2020

Thanks all!
@camelid camelid deleted the camelid:checksum branch May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Add checksums for downloads
6 participants
@camelid @highfive @jdm @bors-servo @CYBAI @Manishearth
You can’t perform that action at this time.