Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement `animation-fill-mode` #26519
Conversation
highfive
commented
May 14, 2020
|
Heads up! This PR modifies the following files:
|
|
Note: There is a set of small manual tests in web-platform-tests, but I've added an automated test using Servo's testing time warp functionality. |
|
@bors-servo r=jdm,emilio |
|
|
…,emilio Implement `animation-fill-mode` Fixes #26460. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
Failed in Linux:
and some more tests pass now
|
ea58eeb
to
cd12c38
|
@bors-servo r=jdm,emilio |
|
|
…,emilio Implement `animation-fill-mode` Fixes #26460. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
cd12c38
to
183f15d
|
Okay. I've updated the change to include the ini file and have also rebased the layout_2020 test results for this directory. The tests will fail because support for animations in layout 2020 hasn't landed yet. |
|
@bors-servo r+ |
|
|
|
|
mrobinson commentedMay 14, 2020
Fixes #26460.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors