Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file extension for Linux nightly #26524

Merged
merged 1 commit into from May 14, 2020
Merged

Fix file extension for Linux nightly #26524

merged 1 commit into from May 14, 2020
+3 −3

Conversation

@camelid
Copy link
Contributor

camelid commented May 14, 2020

Fix file extension for the Linux nightly download. It should be published as servo-latest.tar.gz but was instead published as servo-latest.gz.

  • ./mach build -d does not report any errors (doesn't change Rust code)
  • ./mach test-tidy does not report any errors
  • These changes fix #26522 (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because this is an infrastructure bug fix
@camelid
Fix file extension for Linux nightly
Loading status checks…
1b36a7c
@highfive
Copy link

highfive commented May 14, 2020

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @ferjm (or someone else) soon.
@highfive
Copy link

highfive commented May 14, 2020

Heads up! This PR modifies the following files:
@camelid
Copy link
Contributor Author

camelid commented May 14, 2020

r? @jdm
@highfive highfive assigned jdm and unassigned ferjm May 14, 2020
@jdm
Copy link
Member

jdm commented May 14, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 14, 2020

📌 Commit 1b36a7c has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented May 14, 2020

⌛ Testing commit 1b36a7c with merge 0c56a17...
bors-servo added a commit that referenced this pull request May 14, 2020
@bors-servo
Auto merge of #26524 - camelid:camelid-patch-1, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0c56a17 
Fix file extension for Linux nightly

<!-- Please describe your changes on the following line: -->
Fix file extension for the Linux nightly download. It should be published as `servo-latest.tar.gz` but was instead published as `servo-latest.gz`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors (doesn't change Rust code)
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #26522 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because this is an infrastructure bug fix

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented May 14, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented May 14, 2020

@bors-servo retry
@camelid
Copy link
Contributor Author

camelid commented May 14, 2020

Why are the tests failing?
@jdm
Copy link
Member

jdm commented May 14, 2020

We have many tests that intermittently fail for various reasons. Many of those failures are restricted to a particular test and those failures can be filtered out of the logs. Some failures occur deeper in the platform and can affect a much wider set of tests, so we have to manually retry those because we can't easily filter them out of the CI results.
@bors-servo
Copy link
Contributor

bors-servo commented May 14, 2020

⌛ Testing commit 1b36a7c with merge 3acc0f9...
@camelid
Copy link
Contributor Author

camelid commented May 14, 2020 •
edited

We have many tests that intermittently fail for various reasons. Many of those failures are restricted to a particular test and those failures can be filtered out of the logs. Some failures occur deeper in the platform and can affect a much wider set of tests, so we have to manually retry those because we can't easily filter them out of the CI results.

Ah, thanks for the explanation! Sounds frustrating to deal with :(
@bors-servo
Copy link
Contributor

bors-servo commented May 14, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 3acc0f9 to master...
@bors-servo bors-servo merged commit 3acc0f9 into servo:master May 14, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@camelid camelid deleted the camelid:camelid-patch-1 branch May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Linux nightly builds are named incorrectly
5 participants
@camelid @highfive @jdm @bors-servo @ferjm
You can’t perform that action at this time.