Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file extension for Linux nightly #26524

Merged
merged 1 commit into from May 14, 2020
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Fix file extension for Linux nightly

  • Loading branch information
camelid committed May 14, 2020
commit 1b36a7cf96fd03d20fbb6bd0771a0ec18002b938
@@ -628,8 +628,8 @@ def upload_to_s3(platform, package, timestamp):
nightly_dir = 'nightly/{}'.format(platform)
filename = nightly_filename(package, timestamp)
package_upload_key = '{}/{}'.format(nightly_dir, filename)
extension = path.splitext(path.basename(package))[1]
latest_upload_key = '{}/servo-latest{}'.format(nightly_dir, extension)
extension = path.basename(package).partition('.')[2]
latest_upload_key = '{}/servo-latest.{}'.format(nightly_dir, extension)

# Compute the hash
SHA_BUF_SIZE = 1048576 # read in 1 MiB chunks
@@ -642,7 +642,7 @@ def upload_to_s3(platform, package, timestamp):
sha256_digest.update(data)
package_hash = sha256_digest.hexdigest()
package_hash_fileobj = io.BytesIO(package_hash)
latest_hash_upload_key = '{}/servo-latest{}.sha256'.format(nightly_dir, extension)
latest_hash_upload_key = '{}/servo-latest.{}.sha256'.format(nightly_dir, extension)

s3.upload_file(package, BUCKET, package_upload_key)

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.