Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Cargo.toml cleanups #26526

Merged
merged 1 commit into from May 15, 2020
Merged

More Cargo.toml cleanups #26526

merged 1 commit into from May 15, 2020

Conversation

@atouchet
Copy link
Contributor

atouchet commented May 15, 2020

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___
@atouchet
More Cargo.toml cleanups
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d132866
@highfive
Copy link

highfive commented May 15, 2020

Heads up! This PR modifies the following files:

  • @emilio: components/layout/Cargo.toml
@highfive
Copy link

highfive commented May 15, 2020

warning Warning warning

  • These commits modify gfx and layout code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented May 15, 2020

@bors-servo r+
thanks!
@bors-servo
Copy link
Contributor

bors-servo commented May 15, 2020

📌 Commit d132866 has been approved by jdm
@highfive highfive assigned jdm and unassigned asajeffrey May 15, 2020
@bors-servo
Copy link
Contributor

bors-servo commented May 15, 2020

⌛ Testing commit d132866 with merge b9b569a...
@bors-servo
Copy link
Contributor

bors-servo commented May 15, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing b9b569a to master...
@bors-servo bors-servo merged commit b9b569a into servo:master May 15, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request May 15, 2020
Merged
4 of 4 tasks complete
@atouchet atouchet deleted the atouchet:crgo branch May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@atouchet @highfive @jdm @bors-servo @asajeffrey
You can’t perform that action at this time.