Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout_2020: Fix WebRender display list dumping #26527

Merged
merged 1 commit into from May 15, 2020
Merged

layout_2020: Fix WebRender display list dumping #26527

merged 1 commit into from May 15, 2020
+8 −4

Conversation

@mrobinson
Copy link
Member

mrobinson commented May 15, 2020

We need to enable display list serialization before building the display
list for it to work properly.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because they just fix debug output.
@mrobinson mrobinson requested a review from nox May 15, 2020
@SimonSapin
Copy link
Member

SimonSapin commented May 15, 2020

If we print a display list before creating it, won’t this print an empty list?
@mrobinson
Copy link
Member Author

mrobinson commented May 15, 2020 •
edited

This method's name is a little confusing. It prepares the display list for printing a text version during finalize(). If you call it after adding display list items, they aren't added to the serialized content buffer.

https://github.com/servo/webrender/blob/master/webrender_api/src/display_list.rs#L1092
@SimonSapin
Copy link
Member

SimonSapin commented May 15, 2020

Ah I see. Please add a comment on the dump_serialized_display_list call to explain that it doesn’t print anything now but enables printing when items are added later. r+ with that.
@mrobinson
layout_2020: Fix WebRender display list dumping
Loading status checks…
0111042 
We need to enable display list serialization before building the display
list for it to work properly.
@mrobinson mrobinson force-pushed the mrobinson:layout2020-fix-display-list-dumping branch from 06350f3 to 0111042 May 15, 2020
@mrobinson
Copy link
Member Author

mrobinson commented May 15, 2020

@bors-servo r=SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented May 15, 2020

📌 Commit 0111042 has been approved by SimonSapin
@highfive highfive assigned SimonSapin and unassigned jdm May 15, 2020
@bors-servo
Copy link
Contributor

bors-servo commented May 15, 2020

⌛ Testing commit 0111042 with merge 25042b0...
bors-servo added a commit that referenced this pull request May 15, 2020
@bors-servo
Auto merge of #26527 - mrobinson:layout2020-fix-display-list-dumping,…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
25042b0 
… r=SimonSapin

layout_2020: Fix WebRender display list dumping

We need to enable display list serialization before building the display
list for it to work properly.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because they just fix debug output.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented May 15, 2020

💔 Test failed - status-taskcluster
@mrobinson
Copy link
Member Author

mrobinson commented May 15, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 15, 2020

⌛ Testing commit 0111042 with merge ef54bd6...
@bors-servo
Copy link
Contributor

bors-servo commented May 15, 2020

☀️ Test successful - status-taskcluster
Approved by: SimonSapin
Pushing ef54bd6 to master...
@bors-servo bors-servo merged commit ef54bd6 into servo:master May 15, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@mrobinson mrobinson deleted the mrobinson:layout2020-fix-display-list-dumping branch May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nox nox

Assignees

@SimonSapin SimonSapin

Labels
A-layout/2020
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@mrobinson @SimonSapin @bors-servo @jdm @highfive
You can’t perform that action at this time.