Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for faster reversing of interrupted transitions #26540
Conversation
highfive
commented
May 15, 2020
|
Heads up! This PR modifies the following files:
|
atouchet
changed the title
|
@bors-servo r+ is there a reason that test is not in the main WPT folder? |
|
|
bors-servo
added a commit
that referenced
this pull request
May 18, 2020
…shearth Add support for faster reversing of interrupted transitions This is described in the spec and allows interrupted transitions to reverse in a more natural way. Unfortunately, most of the tests that exercise this behavior use the WebAnimations API. This change adds a test using our custom clock control API. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
|
This should be fixed once #26486 lands. |
Thanks for the review! WPT has minimal testing of this feature, but it seems to use the Web Animations API (which we don't support). I've added a test, but it uses our custom animation tick / time warp driver, so it isn't a good candidate for inclusion in WPT. |
|
@bors-servo try=wpt-2020 |
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
May 19, 2020
Add support for faster reversing of interrupted transitions This is described in the spec and allows interrupted transitions to reverse in a more natural way. Unfortunately, most of the tests that exercise this behavior use the WebAnimations API. This change adds a test using our custom clock control API. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
mrobinson
force-pushed the
mrobinson:transition-shortening-factor
branch
from
21e35a9
to
984d20e
mrobinson
force-pushed the
mrobinson:transition-shortening-factor
branch
from
984d20e
to
1bf1b8e
|
@bors-servo try=wpt-2020 |
bors-servo
added a commit
that referenced
this pull request
May 19, 2020
Add support for faster reversing of interrupted transitions This is described in the spec and allows interrupted transitions to reverse in a more natural way. Unfortunately, most of the tests that exercise this behavior use the WebAnimations API. This change adds a test using our custom clock control API. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
|
Oof. Looks like I'll need to do an approximate check for the expected value in this test. |
This is described in the spec and allows interrupted transitions to reverse in a more natural way. Unfortunately, most of the tests that exercise this behavior use the WebAnimations API. This change adds a test using our custom clock control API.
mrobinson
force-pushed the
mrobinson:transition-shortening-factor
branch
from
1bf1b8e
to
4ba15c3
|
Okay. I've posted a new version of this branch that uses approximate (±1 pixel) checks everywhere. I think we are bumping into issues where layout_2020 is calculating a slightly different value for widths. |
|
@bors-servo try=wpt-2020 |
bors-servo
added a commit
that referenced
this pull request
May 20, 2020
Add support for faster reversing of interrupted transitions This is described in the spec and allows interrupted transitions to reverse in a more natural way. Unfortunately, most of the tests that exercise this behavior use the WebAnimations API. This change adds a test using our custom clock control API. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo r=Manishearth |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedMay 15, 2020
This is described in the spec and allows interrupted transitions to
reverse in a more natural way. Unfortunately, most of the tests that
exercise this behavior use the WebAnimations API. This change adds a
test using our custom clock control API.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors