Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate copybuffertobuffer() + some spec update #26541

Merged
merged 1 commit into from May 16, 2020

Conversation

@kunalmohan
Copy link
Collaborator

kunalmohan commented May 15, 2020

The spec update includes renaming bindings to entries, adding CommandEncoderState and renaming GPUBufferSize to GPUSize64.

r?@jdm @kvark


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___
@highfive
Copy link

highfive commented May 15, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/gpubindgrouplayout.rs, components/script/dom/webidls/GPUComputePassEncoder.webidl, components/script/dom/webidls/GPUBindGroupLayout.webidl, components/script/dom/gpucomputepassencoder.rs, components/script/dom/gpubuffer.rs and 6 more
  • @KiChjang: components/script/dom/gpubindgrouplayout.rs, components/script/dom/webidls/GPUComputePassEncoder.webidl, components/script/dom/webidls/GPUBindGroupLayout.webidl, components/script/dom/gpucomputepassencoder.rs, components/script/dom/gpubuffer.rs and 6 more
@highfive
Copy link

highfive commented May 15, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm jdm assigned kvark and unassigned jdm May 15, 2020
The spec update includes renaming bindings to entries and
adding CommandEncoderState.
@kunalmohan kunalmohan force-pushed the kunalmohan:copy-buffer-to-buffer branch from 6ffcd66 to 1aeae47 May 15, 2020
@kvark
kvark approved these changes May 15, 2020
Copy link
Member

kvark left a comment

Thanks!
Don't forget to click "Resolve conversation" for items you address. This helps us see what is WIP and what not.

@kunalmohan kunalmohan added this to In progress in WebGPU MVP via automation May 15, 2020
@jdm
Copy link
Member

jdm commented May 15, 2020

@bors-servo r=kvark,jdm

@bors-servo
Copy link
Contributor

bors-servo commented May 15, 2020

📌 Commit 1aeae47 has been approved by kvark,jdm

@bors-servo
Copy link
Contributor

bors-servo commented May 16, 2020

Testing commit 1aeae47 with merge 1a74382...

@bors-servo
Copy link
Contributor

bors-servo commented May 16, 2020

☀️ Test successful - status-taskcluster
Approved by: kvark,jdm
Pushing 1a74382 to master...

@bors-servo bors-servo merged commit 1a74382 into servo:master May 16, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
WebGPU MVP automation moved this from In progress to Done May 16, 2020
@kunalmohan kunalmohan deleted the kunalmohan:copy-buffer-to-buffer branch May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
WebGPU MVP
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.