Introduce import.meta hook for module script

[CYBAI]

---

• ./mach build -d does not report any errors
• ./mach test-tidy does not report any errors
• These changes fix #26542
• There are tests for these changes under module/import-meta folder.

[highfive]

Heads up! This PR modifies the following files:

• @asajeffrey: components/script/script_module.rs
• @jgraham: tests/wpt/include.ini
• @KiChjang: components/script/script_module.rs

[highfive]

Warning

• These commits modify unsafe code. Please review it carefully!

[CYBAI]

r? @jdm

[jdm]

Ensuring the resulting strings don't contain random memory should help!

[CYBAI]

@jdm fixing with what you pointed out, we can pass the test now!

Ensuring the resulting strings don't contain random memory should help!

but, I still don't understand what you mean for contain random memory here 🤔
does that mean, while using JS_NewStringCopyZ, it's possible to return an empty string which might cause different memory in each run?

btw, how can I know when I'll need a null-terminated string 🤔 ? thanks!

[jdm]

If an API expects a null-terminated string and we pass a string constant without one, whatever values are present in memory following the string contents will be included until there's a null value encountered. That's why the test failed, because we ended setting a property named something like "urlZzta3#';(84, x?&".

In general, any C aoi that accepts a chat* argument that is intended to be a name or string value should be null terminated unless there's a length argument included. In the string copy API in particular, the Z suffix stands for "zero", which means null-terminated. The N suffix stands for "length" and accepts an argument that includes an end pointer.

[jdm]

I suspect this needs a fmt, but otherwise it looks fine.

[CYBAI]

If an API expects a null-terminated string and we pass a string constant without one, whatever values are present in memory following the string contents will be included until there's a null value encountered. That's why the test failed, because we ended setting a property named something like "urlZzta3#';(84, x?&".

In general, any C aoi that accepts a chat* argument that is intended to be a name or string value should be null terminated unless there's a length argument included. In the string copy API in particular, the Z suffix stands for "zero", which means null-terminated. The N suffix stands for "length" and accepts an argument that includes an end pointer.

I see! That's very clear and I understand now! Thanks! :D

I suspect this needs a fmt, but otherwise it looks fine.

Wait me a minute! Looks like I need to upgrade my local fmt 🤔

[CYBAI]

oh, it's not a fmt error from rustfmt :P

[jdm]

@bors-servo r+

[bors-servo]

📌 Commit 6bc6240 has been approved by jdm

[bors-servo]

⌛ Testing commit 6bc6240 with merge 5a99b5e...

[bors-servo]

💔 Test failed - status-taskcluster

[jdm]

@bors-servo retry
#24622

[bors-servo]

⌛ Testing commit 6bc6240 with merge 619e0bc...

[bors-servo]

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 619e0bc to master...