Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to handle per-view eye transforms #26551

Merged
merged 5 commits into from May 18, 2020
Merged

Update to handle per-view eye transforms #26551

merged 5 commits into from May 18, 2020
+143 −133

Conversation

@Manishearth
Copy link
Member

Manishearth commented May 17, 2020

Depends on servo/webxr#175
@Manishearth Manishearth requested a review from asajeffrey May 17, 2020
@highfive
Copy link

highfive commented May 17, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/xrreferencespace.rs, components/script/dom/xrwebgllayer.rs, components/script/dom/bindings/trace.rs, components/script/dom/xrviewerpose.rs, components/script/dom/xrsession.rs and 2 more
  • @KiChjang: components/script/dom/xrreferencespace.rs, components/script/dom/xrwebgllayer.rs, components/script/dom/bindings/trace.rs, components/script/dom/xrviewerpose.rs, components/script/dom/xrsession.rs and 2 more
@highfive
Copy link

highfive commented May 17, 2020

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!
@Manishearth Manishearth assigned asajeffrey and unassigned jdm May 18, 2020
@Manishearth Manishearth mentioned this pull request May 18, 2020
Closed
@asajeffrey
asajeffrey approved these changes May 18, 2020
View changes
Copy link
Member

asajeffrey left a comment

LGTM
@Manishearth Manishearth mentioned this pull request May 18, 2020
Merged
bors-servo added a commit to servo/webxr that referenced this pull request May 18, 2020
@bors-servo
Auto merge of #175 - Manishearth:per-view, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0d8d2af 
Send eye positions per-view, relative to the native space

Fixes #173

This contains many related changes:

 - Makes the views state per-frame
 - Makes viewports no longer part of the views state, and only occasionally updated
 - Switches view transforms to being native-relative (and related cleanups in openxr, reducing the number of `locate_views` calls)
 - Caching of projection matrices in openxr
 - Cleanups of the headless backend to support multiple sessions on the same device (only relevant for inline)

Overall this should improve stability with a _tiny_ performance win from not doing as much space-locating each frame.

servo side: servo/servo#26551
Manishearth added 5 commits May 13, 2020
@Manishearth
Make views a per-frame deal
7088247
@Manishearth
Use cached projection matrix
eaad692
@Manishearth
Move viewports to being per-session, not per-frame
794624b
@Manishearth
Update to use webxr_api::ViewerPose
a97dcd9
@Manishearth
Update to treat view transforms as native-relative
Loading status checks…
d627476
@Manishearth Manishearth force-pushed the Manishearth:per-view branch from a321ecc to d627476 May 18, 2020
@Manishearth Manishearth marked this pull request as ready for review May 18, 2020
@Manishearth
Copy link
Member Author

Manishearth commented May 18, 2020

@bors-servo r=asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2020

📌 Commit d627476 has been approved by asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2020

⌛ Testing commit d627476 with merge c183f95...
@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2020

☀️ Test successful - status-taskcluster
Approved by: asajeffrey
Pushing c183f95 to master...
@bors-servo bors-servo merged commit c183f95 into servo:master May 18, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@Manishearth Manishearth deleted the Manishearth:per-view branch May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asajeffrey asajeffrey

Assignees

@asajeffrey asajeffrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Manishearth @highfive @bors-servo @asajeffrey @jdm
You can’t perform that action at this time.