Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade wgpu version to "0.5.0" and add server-side code for id recycling for WebGPU #26564
Conversation
highfive
commented
May 18, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
May 18, 2020
|
@kvark could you take a look at this before I proceed further? |
|
Thank you, this is one of the critical things we were missing! |
|
It was difficult to upgrade to 0.5 without implementing the IdentityRecyclerFactory, so I have completed the task here itself. This PR now covers the following-
|
|
The upgrade has introduced duplicate dependencies-
I tried resolving them with |
Then we need a separate PR to Servo that bumps parking_lot, another one that bumps RON. |
|
You can add duplicates to servo-tidy.toml if it's not straightforward to update the packages that depend on the older versions. |
|
And yes, the output from tidy in that case is less helpful than it could be: #25508 |
|
@jdm parking_lot is a dependency of many packages, one of which is |
|
opening pull requests can't hurt! |
|
but yes, no need to gate this PR on those other repositories. |
|
I have made the required changes and squashed the commits. |
…r wgpu id recycling Remove current implementation of MapReadAsync
|
@bors-servo r=kvark |
|
|
Upgrade wgpu version to "0.5.0" and add server-side code for id recycling for WebGPU <!-- Please describe your changes on the following line: --> I have updated the cargo.lock to use a wgpu-core at a more recent commit where IdentityHandlerFactory was introduced. r?@kvark --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
|
This is rust-lang/rust#70874, which was fixed. Sounds like we need a rustc version update in Servo before moving on? |
|
@kunalmohan You should be able to change the nightly version in the rust-toolchain file to any nightly that is older than 5/19/2020. |
|
I was getting this warning at a few places after toolchain update- |
|
@bors-servo r+ |
|
|
|
|
kunalmohan commentedMay 18, 2020
I have updated the cargo.lock to use a wgpu-core at a more recent commit where IdentityHandlerFactory was introduced.
r?@kvark
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors