Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdapt layout 2020 viewer to new BoxTree and FragmentTree structs #26565
Conversation
|
r? @SimonSapin |
|
@SimonSapin review ping. |
|
@SimonSapin Another review ping. |
|
Sorry for the delay. I’ve followed the instructions in @bors-servo r+ |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ferjm commentedMay 19, 2020
•
edited
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors#26414 introduced some changes to how we represent the box and fragment trees, so we need to adapt the layout viewer to support them.